Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#4026 closed defect (fixed)

TINSEL: Graphic Flickers

Reported by: SF/vorph999 Owned by: wjp
Priority: normal Component: Engine: Tinsel
Keywords: Cc:
Game: Discworld II

Description

The animations of Rincewind and the
text of the subtitles are flickering

Tested on Win Vista Ultimate SP1 x86 32 Bit
ScummVM used 0.13.0 SVN Revision 35288

Game Version:

Initial (?) German 2CD Version of Discworld II

Screenshots attached

Ticket imported from: #2409385. Ticket imported from: bugs/4026.

Attachments (2)

character.jpg (66.3 KB ) - added by SF/vorph999 11 years ago.
subtitles.jpg (66.9 KB ) - added by SF/vorph999 11 years ago.

Download all attachments as: .zip

Change History (12)

by SF/vorph999, 11 years ago

Attachment: character.jpg added

by SF/vorph999, 11 years ago

Attachment: subtitles.jpg added

comment:1 by SF/vorph999, 11 years ago

File Added: subtitles.jpg

comment:2 by SF/vorph999, 11 years ago

Summary: Graphic FlickersTINSEL Graphic Flickers

comment:3 by SF/vorph999, 11 years ago

Summary: TINSEL Graphic FlickersTINSEL: Graphic Flickers

comment:4 by dreammaster, 11 years ago

The first posibility is that your data got copied incorrectly off the CDs. You might want to verify that the problem still exists even after making a fresh copy. It wouldn't be the first time a bug turned out to be bad data.

Presuming that this isn't the case, it's possible that the German version has data that exposes a bug in the graphics renderer - the original had the renderers implemented in assembly, and additionally had different versions for when the image was clipped and/or horizontally flipped. As part of the development process, I merged the variations into a single C routine for each graphics renderer, rather than having variations of each. As such, it's possible that the renderer code has a bug that only exhibits itself for certain data.

Unfortunately, I don't have a copy of the German version to do any tests on, so I'll have to leave this as an open bug.. hopefully someone else with the German version can look into it further. The two main renderers in Tinsel 2 are t2WrtNonZero and PackedWrtNonZero.

comment:5 by SF/vorph999, 11 years ago

Hello,

for now - and I think for ever :) - you can close this bug report... After comparing my files and so on, I decided
to download a current SVN Build, and not to use my VS2008 compilation. (straight of the trunk, no changes made)

The error is GONE, whatever you did (if someone did something)

Thanks...seems like I'm doing something wrong when compiling from the source

comment:6 by dreammaster, 11 years ago

Status: newclosed

comment:7 by sev-, 11 years ago

Resolution: invalid

comment:8 by bluegr, 11 years ago

The actual cause for this has been fixed in commit #35414

comment:9 by wjp, 11 years ago

Resolution: invalidfixed

comment:10 by Kirben, 10 years ago

Owner: set to wjp
Note: See TracTickets for help on using tickets.