Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#4020 closed defect (fixed)

TINSEL: Wrong detection for "Discworld 1" Italian CDROM

Reported by: hkzlab Owned by: hkzlab
Priority: normal Component: Engine: Tinsel
Keywords: detection Cc:
Game: Discworld

Description

Tested with SVN rev.35236
I get my Italian discworld cdrom recognized as an "english/floppy" version: the game should have italian subs and english voice.

Scummvm runned with "-d3" print this at the console while detecting the game:
Starting detection
+ dw.gra
> 'dw.gra': 'c8808ccd988d603dd35dff42013ae7fd'
+ english.smp
> 'english.smp': '4710bd5cc788df1d517370d43abe1101'
Matched file: dw.gra
Found game: dw (Floppy DOS/English) (0)
... new best match, removing all previous candidates
Matched file: dw.gra
Matched file: english.smp
Matched file: dw.gra
Matched file: english.smp
Matched file: dw.gra
Matched file: english.smp
Matched file: dw.gra
Matched file: english.smp

I have attached the md5 checksum for all game files i copied from my cdrom.

Need some more info?

Ticket imported from: #2389432. Ticket imported from: bugs/4020.

Attachments (2)

md5output.txt (6.9 KB ) - added by hkzlab 11 years ago.
md5 checksum for all game files
discw-cd.txt (4.3 KB ) - added by hkzlab 11 years ago.
Discworld cd files

Download all attachments as: .zip

Change History (18)

by hkzlab, 11 years ago

Attachment: md5output.txt added

md5 checksum for all game files

comment:1 by hkzlab, 11 years ago

My wrong. It wasn't svn revision 35236 i tested with, but with an old copy from yesterday.
With current revision it gets detected as a CD version, but as an ENGLISH one, not italian.
Works good anyway though...

comment:2 by fingolfin, 11 years ago

Can you give us a list of all files you have? In particular, anything named italian.* or so?

comment:3 by fingolfin, 11 years ago

Summary: [Tinsel] Wrong detection for "Discworld 1" Italian CDROMTINSEL: Wrong detection for "Discworld 1" Italian CDROM

comment:4 by fingolfin, 11 years ago

Component: Engine: Tinsel
Game: Discworld

comment:5 by bluegr, 11 years ago

That specific version is already supported, it's a multi-language version with English speech and French, German, Italian and Spanish (but not English) subtitles. You need to copy all the *.txt files from the CD (i.e. french.txt, german.txt, italian.txt and spanish.txt) in order to get it detected properly. You can then choose the Italian version from the list of available versions

comment:6 by hkzlab, 11 years ago

Well, i've just checked the cdrom, there are no german.txt, french.txt, spanish.txt or italian.txt files. There is just english.txt and running "strings" on it gives me the italian text of the game.
Maybe we spotted a different game edition?

by hkzlab, 11 years ago

Attachment: discw-cd.txt added

Discworld cd files

comment:7 by hkzlab, 11 years ago

I'm attaching the output of "find" on the cd mount directory.

File Added: discw-cd.txt

comment:8 by fingolfin, 11 years ago

I have a similar thing with a german version which masquerades as the english one, by putting the german text into "english.txt". In my case, dw.svn had a unique MD5 checksum, though. But I guess we could add a detection entry for your version by using the MD5 checksum of your english.txt file...

comment:9 by dreammaster, 11 years ago

Fingolfin - what's the status of this entry. Can it be closed?

comment:10 by hkzlab, 11 years ago

As of svn rev 36121 my Italian Discworld version still gets detected as english.
The game plays fine though.

comment:11 by fingolfin, 11 years ago

I haven't done anything about it yet. I would need to know the *size* of english.txt, as well as the checksum of the first 5000 bytes. And/or english.smp.

comment:12 by hkzlab, 11 years ago

I can provide you the needed info:
english.txt is 237774 bytes, english.smp is 343755891 bytes.
I have then extracted the first 5000bytes of both files (dd bs=5000 count=1 if=xxx of=xxx), here are the sums:
the first 5000b of english.smp hash is 4710bd5cc788df1d517370d43abe1101, for english.txt is 15f0703f85477d7fab4280bf938b61c1.

comment:13 by sev-, 10 years ago

What is the status of this item?

comment:14 by hkzlab, 10 years ago

I added the proper detection entry for my italian CD version.

comment:15 by hkzlab, 10 years ago

Resolution: fixed
Status: newclosed

comment:16 by Kirben, 10 years ago

Owner: set to hkzlab
Note: See TracTickets for help on using tickets.