Opened 11 years ago

Closed 11 years ago

#3816 closed defect (fixed)

MMNES : Incorrect detection (US/GB)

Reported by: SF/sanguinehearts Owned by: sev-
Priority: high Component: Engine: SCUMM
Keywords: detection Cc:
Game: Maniac Mansion

Description

Hello,
I recently decided to get hold of a copynes and dump my maniac mansion cartridges, I happen to own a USA version and a UK version, now after dumping these I ran them through an emulator to check I had dumped the correctly.

As expected the USA version displays Nintendo of America on its title screen, however the UK version does not.

I then extracted these dumps with the extraction tool and they were detected correctly. however when I add them to ScummVM the USA version is detected as English (GB) while the UK version is detected as English (US)

The issue also occurs when you just feed ScummVM the raw .PRG data

This isnt really an issue as it doesnt affect gameplay
I just wanted to document it here so someone can fix it when they have less critical things to work on

Rob

Ticket imported from: #2020561. Ticket imported from: bugs/3816.

Attachments (1)

scumm-md5.txt.diff (1.1 KB ) - added by SF/sanguinehearts 11 years ago.
correct patch

Download all attachments as: .zip

Change History (9)

comment:1 by SF/sanguinehearts, 11 years ago

Summary: Incorrect detection (US/GB)MMNES : Incorrect detection (US/GB)

comment:2 by sev-, 11 years ago

Owner: set to sev-

comment:3 by sev-, 11 years ago

Priority: normalhigh

comment:4 by sev-, 11 years ago

Raising priority. This bug is nice to get fixed before the release.

comment:5 by SF/sanguinehearts, 11 years ago

patch attached to fix this
File Added: scumm-md5.h.diff

by SF/sanguinehearts, 11 years ago

Attachment: scumm-md5.txt.diff added

correct patch

comment:6 by SF/sanguinehearts, 11 years ago

attached the correct patch

File Added: scumm-md5.txt.diff

comment:7 by sev-, 11 years ago

Resolution: fixed
Status: newclosed

comment:8 by sev-, 11 years ago

Thanks, the patch accepted. Bug fixed in both 0.12.0 and trunk

Note: See TracTickets for help on using tickets.