Opened 12 years ago

Closed 11 years ago

Last modified 13 months ago

#3739 closed defect (fixed)

ALL: config manager crashes when reading too long lines

Reported by: eriktorbjorn Owned by: fingolfin
Priority: high Component: --Other--
Keywords: Cc:
Game:

Description

Latest SVN snapshot

It is possible (albeit unlikely) for the config manager to create a config file that cannot be read because the lines are too long. I'm speculating that this is what happened in the following forum thread:

http://forums.scummvm.org/viewtopic.php?t=5679

Where it looks like someone used an extremely long path name for Zak McKracken.

The simplest "solution" is, of course, to simply increase the maximum line length, to make it even less likely to happen. But that doesn't seem pretty.

Ticket imported from: #1971499. Ticket imported from: bugs/3739.

Change History (7)

comment:1 by fingolfin, 12 years ago

Well, either we should support "arbitrarily" long lines, or we should prevent this from happening in the first place...

comment:2 by fingolfin, 11 years ago

Summary: The config manager can create files with too long linesALL: config manager can create files with too long lines

comment:3 by sev-, 11 years ago

Priority: normalhigh

comment:4 by sev-, 11 years ago

Restrict it, say, to 2048 bytes. Raising priority.

comment:5 by fingolfin, 11 years ago

Resolution: fixed
Status: newclosed
Summary: ALL: config manager can create files with too long linesALL: config manager crashes when reading too long lines

comment:6 by fingolfin, 11 years ago

Config manager code has been fixed to handle reading of arbitrarily long lines.

comment:7 by digitall, 13 months ago

Component: --Other--
Note: See TracTickets for help on using tickets.