Opened 16 years ago

Closed 2 years ago

#3712 closed defect (fixed)

ALL: --savepath=PATH broken

Reported by: SF/logicdeluxe Owned by: sev-
Priority: normal Component: GUI
Version: Keywords:
Cc: Game:

Description

ScummVM 0.12.0svn (Apr 30 2008 10:27:14) Features compiled in: Vorbis FLAC MP3 zLib MPEG2 Windows 2000 SP4

The command line option --savepath=PATH doesn't seem to do anything on the svn build as well as in the later releases. 0.8.2 is the last release in which this options works. This example does not work in releases after 0.8.2: scummvm --config=scummvm.ini --savepath="%appdata%\scummvm"

Ticket imported from: #1955075. Ticket imported from: bugs/3712.

Change History (11)

comment:1 by fingolfin, 16 years ago

Owner: set to Kirben
Priority: normal → high
Summary: --savepath=PATH broken → WIN (?): --savepath=PATH broken

comment:2 by fingolfin, 16 years ago

It works great for me under Mac OS X.

Maybe a Windows specific problem. Kirben, can you confirm the issue?

Marek, can you try it with slashes instead of backslashes, just in case?

comment:3 by Kirben, 16 years ago

I can reproduce the problem, but only if I don't select a target name.

'scummvm --savepath=c:/tmp tentacle' uses the correct save path

'scummvm --savepath=c:/tmp' uses the default save path

The slashes aren't important, using forwardslash or backwardslash seems to work fine.

comment:4 by fingolfin, 16 years ago

Owner: changed from Kirben to fingolfin
Summary: WIN (?): --savepath=PATH broken → ALL: --savepath=PATH broken

comment:5 by fingolfin, 16 years ago

Thanks, I see now. This is indeed an old and complicated issue and I think it affects *all* command line settings, not just savepath. Supporting these leads to a certain clash with the options dialog.

Roughly, we don't want to accidentally overwrite the savepath set in the config file by the temporary savepath, which could/would happen when the user uses the options dialog.

comment:6 by SF/islanti, 16 years ago

This does not affect all command line options. I'm trying to use the following: --savepath=%U3_APP_DATA_PATH%\Save --extrapath=%U3_DEVICE_EXEC_PATH% --themepath=%U3_DEVICE_EXEC_PATH% --config=%U3_APP_DATA_PATH%\scummvm.ini

The last 3 work fine however the --savepath parameter seems to be ignored when a config file is specified.

It seems like a bug that command line options override config file options EXCEPT for --savepath. What's strange, though, is that Scumm is CHECKING the --savepath specified parameter because if that folder does not exist ScummVM.exe complains and exits.

comment:7 by fingolfin, 15 years ago

Well, this happens because launcherDialog() clears the kTransientDomain domain; and this should actually also affect the extrapath & themepath, only that it's less noticable there, since the themepath is not needed anymore once the theme has been loaded.

So, despite all, this is still a generic problem, a deep conflict caused by our attempt to simultaneously support a command line and a graphical interface.

comment:8 by fingolfin, 13 years ago

Owner: fingolfin removed

comment:9 by Mataniko, 6 years ago

Component: --Unset-- → GUI

This still reproduces for me in ScummVM 2.0.0.

To summarize, once the GUI loads, the configuration in the GUI overrides what was passed through via the command line.

comment:10 by sev-, 4 years ago

Priority: high → normal

comment:11 by sev-, 2 years ago

Owner: set to sev-
Resolution: → fixed
Status: new → closed

Fixed.

Note: See TracTickets for help on using tickets.