Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#3547 closed defect (fixed)

NIPPON: Credits music stopped early in demo

Reported by: Kirben Owned by: peres
Priority: normal Component: Engine: Parallaction
Keywords: Cc:
Game: Nippon Safes

Description

ScummVM 0.12.0svn (Jan 5 2008 09:38:09)
Compiled under mingw with GCC 4.2.1
Running on Windows XP Media Center 2005 Edition
English Amiga demo of Nippon Safes.

The music in the credits sequence at the end of the demo, is stopped too early. The music is stopped after the display of credits finishes under ScummVM. But the music just continues/loops in the original Amiga demo.

Ticket imported from: #1864270. Ticket imported from: bugs/3547.

Attachments (1)

music.diff (566 bytes ) - added by Kirben 12 years ago.
Patch

Download all attachments as: .zip

Change History (9)

comment:1 by peres, 12 years ago

Nippon Safes uses Audio::makeProtrackerStream to create its music streams. That routine can't create a looping stream right now (for reasons I don't know), so the only way to fix this bug would be to extend it.

I can do this if it is ok even in the current situation of feature-freeze, but would like to know if there are any good reasons for which it hasn't already been implemented.

comment:2 by Kirben, 12 years ago

Isn't the actual problem the music is been stopped in this case though?

If I enable audio debug output I see:
AmigaSoundMan::stopMusic()

Just as the display of the credits is finished.

by Kirben, 12 years ago

Attachment: music.diff added

Patch

comment:3 by Kirben, 12 years ago

See the attached patch, for a possible solution.

I'm not sure if the change should apply to the full Amiga version of Nippon Safes though.
File Added: music.diff

comment:4 by sev-, 11 years ago

What is the status of this item?

comment:5 by peres, 11 years ago

Status: newpending

comment:6 by peres, 11 years ago

Solved in revision r38664 (r38665 for branch 0-13-0).

comment:7 by Kirben, 11 years ago

Yes, definitely fixed now.

comment:8 by Kirben, 11 years ago

Resolution: fixed
Status: pendingclosed
Note: See TracTickets for help on using tickets.