Opened 12 years ago

Closed 12 years ago

Last modified 6 months ago

#3312 closed defect (fixed)

SCUMM: Compilation problem in gfx.cpp

Reported by: SF/thomasklausner Owned by:
Priority: normal Component: Engine: SCUMM
Keywords: build Cc:
Game:

Description

Compilation of SVN version from last night on NetBSD-4.99.22/amd64 failed with:
c++ -Wp,-MMD,"engines/scumm/.deps/gfx.d",-MQ,"engines/scumm/gfx.o",-MP -Wall -O2 -I/usr/pkg\
/include -I/usr/include -DGLX_GLXEXT_LEGACY -I/usr/pkg/include -I/usr/include -DGLX_GLXEXT_\
LEGACY -g -ansi -W -Wno-unused-parameter -Wno-long-long -Wno-multichar -Wno-unknown-pragmas\
-pedantic -Wpointer-arith -Wcast-qual -Wconversion -Wshadow -Wimplicit -Wundef -Wnon-virtu\
al-dtor -Wno-reorder -Wwrite-strings -fno-rtti -fno-exceptions -fcheck-new -DHAVE_CONFIG_H \
-DUNIX -DDATA_PATH=\"/usr/pkg/share/scummvm\" -DSDL_BACKEND -I. -I. -I./engines -I/usr/pkg/\
include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -D_THREAD_SAFE -c engines/scumm/gfx.cpp -o engines\
/scumm/gfx.o
engines/scumm/gfx.cpp: In member function 'void Scumm::ScummEngine::drawStripToScreen(Scumm\
::VirtScreen*, int, int, int, int)':
engines/scumm/gfx.cpp:579: error: cast from 'const byte*' to 'int' loses precision

Compiler is gcc (GCC) 4.1.3 20070620 prerelease (NetBSD nb1 20070620).

Ticket imported from: #1751498. Ticket imported from: bugs/3312.

Change History (7)

comment:1 Changed 12 years ago by bluegr

This is strange

First of all, there is no such cast in line 579, but it's at line 599

Second, this looks like an outdated copy of the file. There was a cast from byte to int, but that has been fixed with commit #28012 so that it casts to long instead of int

Can you do an svn up and try again?

comment:2 Changed 12 years ago by fingolfin

Pending response by submitter.

comment:3 Changed 12 years ago by fingolfin

Status: newpending
Summary: Compilation problem in gfx.cppSCUMM: Compilation problem in gfx.cpp

comment:4 Changed 12 years ago by SF/thomasklausner

Resolution: fixed
Status: pendingclosed

comment:5 Changed 12 years ago by SF/thomasklausner

Fixed in latest SVN, thanks.

comment:6 Changed 10 years ago by Kirben

Keywords: build added

comment:7 Changed 6 months ago by digitall

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.