Opened 16 years ago
Closed 15 years ago
Last modified 15 years ago
#3251 closed defect (wontfix)
BS1: Crash while loading saved games
|Reported by:||SF/floydfeeble||Owned by:||sev-|
|Cc:||Game:||Broken Sword 1|
ScummVM version: SVN 0.10.pre 13 June
ScummVM frozes in, while clicking on the button Load.
Language: German Talkie Plattform: Microsoft Windows XP [Version 5.1.2600]
I attached the Saved Games.
Ticket imported from: #1737801. Ticket imported from: bugs/3251.
Change History (15)
by , 16 years ago
comment:1 by , 16 years ago
I can reproduce the problem. It looks like your SAVEGAME.INF is somehow corrupted.
First of all, I'm surprised that it isn't compressed, but that's not in itself a problem.
More seriously, it's supposed to be a bunch of strings (savegame descriptions) separated by a linefeed (10), and terminated with 255. Yours, on the other hand, is a bunch of strings separated by carriage return / linefeed (13 10), and instead of the 255 at the end there's yet another CR+LF. Since Control::readSavegameDescriptions() doesn't check for end of file, it spins forever looking for that terminating 255.
Have you transferred the file between computers in some way? Maybe it misidentified the file as a text file, and decided to silently convert the line feeds to native Windows format?
Either way, I guess that function should be made a bit more robust...
comment:2 by , 16 years ago
In addition, one of the savegame names is long enough to cause an overflow in the 32-byte buffer reserved for each savegame name: "goto girl without being searched"
I don't know how that could have happened, since the save dialog is supposed to only allow 31 characters (not 32 -- one character is reserved for the string terminator), but maybe that sanity check isn't as old as I thought it was...
So, to get it to accept your SAVEGAME.INF, I have to make the following changes:
* Test for end of file. * Test for invalid characters. * Test for too long strings.
All sensible precautions, of course, but I'm still curious how your file could have ended up that way. Sometimes, I really dislike the engines that use a separate "index" file like this for their savegames. If something happens to it, you may not be able to recover...
I've applied my patch. Could you try with the next snapshot and see if you're able to load your savegames. (I'm not, but that's hopefully because I have the English version.)
comment:3 by , 16 years ago
this saved games are from the original brocken sword 1 game. i found them on a disc from the year 2000. with the original game it works without problems.
Therefore i thought there is an error in the scummvm engine
comment:4 by , 16 years ago
Please test whether you can reproduce this bug with the latest daily SVN build which you can find at the bottom of our downloads page: <http://www.scummvm.org/downloads.php>.
comment:5 by , 16 years ago
ScummVM does not generally support the original savegames: http://www.scummvm.org/faq.php#AEN115
I don't know about Broken Sword 1.
comment:6 by , 16 years ago
In the feeble files i can use the old saved games, as well as in other games, like monkey island.
Therefore i thougt i can also use the saved games from broken sword 1
comment:7 by , 16 years ago
You can use old *ScummVM* savegames, aye. But you can *not* use savegames made with the original engines of e.g. Monkey Island.
comment:8 by , 16 years ago
comment:9 by , 16 years ago
The AGOS engine may be savegame compatible with the original, though. At least with the DOS/Windows versions.
I'm tempted to close this bug report as invalid, but I would like to hear from lavosspawn if the Broken Sword 1 engine was ever intended to support the original savegames. (If not, it makes the naming scheme for the savegame files even more annoying.)
comment:10 by , 16 years ago
The fact that original savegames are unsupported is kind of a bug. I should better fix it. However, there're at least three different releases of bs1, I'm not sure if scummvm would ever be able to support all of them...
comment:11 by , 16 years ago
|Summary:||SWORD1: Crash while loading saved games → BS1: Crash while loading saved games|
comment:12 by , 16 years ago
Nah, that's definitely *not* to be considered a bug, at most it's a missing feature. As such I propose to close this report as invalid; if somebody is interested in support for "original" BS1 saves, file a feature request for it.
comment:13 by , 15 years ago
Closing as invalid.
comment:14 by , 15 years ago
|Status:||new → closed|
Here i attached the Saved Games