Opened 13 years ago

Closed 13 years ago

#3114 closed defect (fixed)

AGI: Entering text while screen is shaking

Reported by: eriktorbjorn Owned by: sev-
Priority: normal Component: Engine: AGI
Keywords: Cc:
Game: King's Quest 1

Description

Latest SVN snapshot

Entering text while the screen is shaking (e.g. after falling down the beanstalk for the umpteenth time in King's Quest 1) causes graphics glitches.

I'm guessing that the new text characters are drawn without compensating for the shake offsets.

Ticket imported from: #1678230. Ticket imported from: bugs/3114.

Attachments (3)

kq1.009 (1.1 KB ) - added by eriktorbjorn 13 years ago.
Savegame before planting the beans
bug_1678230_fix.diff (728 bytes ) - added by SF/mthreepwood 13 years ago.
Possible Fix
bug_1678230_fix_2.diff (774 bytes ) - added by SF/mthreepwood 13 years ago.
Possible Fix (fixed)

Download all attachments as: .zip

Change History (11)

comment:1 by sev-, 13 years ago

Ummm... exact steps to reproduce? :)

by eriktorbjorn, 13 years ago

Attachment: kq1.009 added

Savegame before planting the beans

comment:2 by eriktorbjorn, 13 years ago

I've attached a King's Quest 1 savegame. Plant the beans, climb the beanstalk and (simplest of all) fall off. Keep typing rapidly as you land (causing the screen to shake), and you should be able to see it.
File Added: kq1.009

comment:3 by wjp, 13 years ago

The original KQ1 (in dosbox) ignores any keypresses while the screen is shaking.

by SF/mthreepwood, 13 years ago

Attachment: bug_1678230_fix.diff added

Possible Fix

comment:4 by SF/mthreepwood, 13 years ago

I'm attaching a possible patch that disables input while the screen is shaking. But, unfortunately I cannot test it.
File Added: bug_1678230_fix.diff

by SF/mthreepwood, 13 years ago

Attachment: bug_1678230_fix_2.diff added

Possible Fix (fixed)

comment:5 by SF/mthreepwood, 13 years ago

Attaching a second patch to avoid a possible regression.
File Added: bug_1678230_fix_2.diff

comment:6 by eriktorbjorn, 13 years ago

The patch works for me.

comment:7 by sev-, 13 years ago

Owner: set to sev-
Resolution: fixed
Status: newclosed

comment:8 by sev-, 13 years ago

Great, the patch was committed. The bug is fixed.

Note: See TracTickets for help on using tickets.