Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#301 closed defect (fixed)

MI2: Music after loading a save

Reported by: (none) Owned by: eriktorbjorn
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Monkey Island 2

Description

System: P3 866, 256 MB RAM, SB Live!, GeForce 2 GTS, Windows XP Professional

Command line params: scummvm -pe:\monkey2\ -c0 -y100 monkey2

Detected game 'Monkey Island 2: LeChuck's revenge', version 5.2.2 (version from Monkey Island Madness CD-ROM)

Symptom: After loading any sort of a save, I get incomplete music, only the backbeat is playing. The problem is remedied by changing to an area with different music.

Ticket imported from: #566062. Ticket imported from: bugs/301.

Change History (8)

comment:1 by SF/ender, 18 years ago

This is a known problem, and has been forever. However nobody has looked at this into any detail yet.

comment:2 by (none), 18 years ago

Logged In: NO

hiya

I have had the same problem. Lets say on MI2 you are at woodtick and after the save game is re-loaded you get the queer warbled backbeat. As soon as you travel out of woodtick to say another part of the island then the music re-initialises :)

hope this is a little bit of a work around for ya

markfromleeds@yahoo.com

comment:3 by eriktorbjorn, 18 years ago

It sounds like it's playing the right music, but on the wrong instruments. I would guess that the instruments aren't saved/restored properly. I'm still trying to get a basic understanding of the code that handles the music, so I haven't been able to verify it in any way though.

comment:4 by fingolfin, 18 years ago

One way to fix this might be to simply restart the music whenever a game is loaded, no?

comment:5 by fingolfin, 18 years ago

Summary: Music after loading a saveMI2: Music after loading a save

comment:6 by eriktorbjorn, 18 years ago

You mean like adding a player->jump() or player->scan() to fix_players_after_load(). It's not perfect by any means, but it is a marked improvement.

I'll submit a patch.

comment:7 by eriktorbjorn, 18 years ago

The patch was accepted. It doesn't really fix the bug, but it should get it almost right most of the time, and it makes the problem much more bearable. Let me know if there are any problems.

comment:8 by eriktorbjorn, 18 years ago

Owner: set to eriktorbjorn
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.