Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#2765 closed defect (fixed)

KYRA: Crash when launching undefined targets

Reported by: salty-horse Owned by: lordhoto
Priority: normal Component: Engine: Kyra
Keywords: Cc:
Game: Kyrandia 1

Description

Using current svn. When launching scummvm with a target name that is not defined in .scummvmrc, it is searching the current directory.

The following targets crash when trying to launch: kyra2 engines/kyra/sequences_v2.cpp:55: void Kyra::KyraEngine_v2::seq_menu(): Assertion `title->opened()' failed.

fw engines/cine/texte.cpp:50: void Cine::loadTextData(const char*, byte*): Assertion `pFileHandle.isOpen()' failed.

os Same error as fw.

They should atleast check if the first file open they're trying is successful.

The following engines create an entry in the launcher and return to it when failing to launch: sword2 sword2alt sword2demo feeble simon1 simon2 ite ihnm

The agi just target just loads up an empty screen with a green mouse cursor.

In comparison, the SCUMM games handle this nicely by returning an appropriate error in detectGames() which the engine launcher catches: WARNING: ScummEngine: unable to locate game data at path '/tmp'! WARNING: Failed to instantiate engine for target puttputt!

Ticket imported from: #1532649. Ticket imported from: bugs/2765.

Change History (9)

comment:1 by salty-horse, 14 years ago

A quick correction: The error code is returned in Engine_SCUMM_create(), and not in detectGames()

comment:2 by fingolfin, 14 years ago

Aye, that's bad, thanks for pointing this out.

All of these engines should be fixed. It's not OK to create a config ("launcher") entry for a non-existent target, for example...

comment:3 by fingolfin, 14 years ago

Owner: set to lordhoto

comment:4 by lordhoto, 14 years ago

Why is this one assigned to me? I mean it affects other engines as well... I take it that I should only fix kyra engine, or did I get something wrong? I'll unassign it anyway, a splitted bug report would make more sense IMHO.

comment:5 by lordhoto, 14 years ago

Owner: lordhoto removed

comment:6 by fingolfin, 14 years ago

Aye, the second part (targets being added to the config file) is a general bug (and a design problem, too). It should indeed be filed in a separate bug rerport.

But the first part of this tracker item is a bug in the Kyra engine, which is (at least so I thought) maintained by you.

The cine/fw bug should also be refiled separately.

comment:7 by fingolfin, 14 years ago

Component: --Unset--Engine: Kyra
Game: Kyrandia 1
Owner: set to lordhoto
Summary: ALL: Crash when launching undefined targetsKYRA: Crash when launching undefined targets

comment:8 by fingolfin, 14 years ago

The kyra specific crash reported here has been fixed some time ago, closing.

comment:9 by fingolfin, 14 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.