#2741 closed defect (fixed)
SOLARIS: solaris 8 build broken
| Reported by: | SF/wooshell | Owned by: | sev- |
|---|---|---|---|
| Priority: | normal | Component: | Port: Solaris |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
Since the MT32emu was introduced, I'm encountering compilation errors on Solaris 8, probably to C99 conformity issues. Basically, I'd need #ifdef Solaris #define fabsf fabs #define fpowf fpow ... and a few other fmathf functions I can't look up at the moment in the mt32emu/*.c source files.
Changing that by hand for the release binaries is no problem, but for every svn version I build, it's annoying.. please fix ;)
I don't know whether the problem still exists on Solaris 9 or 10, but it does on 8 and below. I don't know how to detect that circumstance reliably (without actually checking for the presence of those functions), but applying the #define on all Solarises shouldn't cause any problems as those functions produce floats anyway, even the versions without -f.
Ticket imported from: #1523129. Ticket imported from: bugs/2741.
Change History (21)
comment:1 by , 18 years ago
| Summary: | small fix neede for solaris 8 build → small fix needed for solaris 8 build |
|---|
comment:2 by , 18 years ago
comment:3 by , 18 years ago
| Status: | new → pending |
|---|
comment:4 by , 18 years ago
This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker).
comment:5 by , 18 years ago
| Status: | pending → closed |
|---|
comment:6 by , 18 years ago
If I had been able to produce a valid patch, I would already have sent it to someone on IRC for submission instead of bothering with the patch tracker here. I have clearly outlined what patch I need for my special case, for someone better skilled to come up with the implementation. Considering that the "problem" is neither a feature request nor a bug report, I was pointed here to request a patch.
comment:7 by , 18 years ago
| Status: | closed → pending |
|---|
comment:8 by , 18 years ago
A patch tracker is there for submitting patches. Not for requesting them.
So, as I understand it, you are requesting that a certain issue ("bug") which affects you (namely that building on Solaris 8 is broken) gets fixed by "someone". Hence this is a bug report, moving to the appropriate tracker.
BTW, we are using C++, so C99 isn't relevant.
comment:9 by , 18 years ago
| Status: | pending → new |
|---|---|
| Summary: | small fix needed for solaris 8 build → SOLARIS: solaris 8 build broken |
comment:10 by , 18 years ago
| Status: | new → pending |
|---|
comment:11 by , 18 years ago
If you tell us what error(s) you get, precisely, we could try to implement a fix... I.e. which functions are "missing" ?
comment:12 by , 18 years ago
This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker).
comment:13 by , 18 years ago
| Status: | pending → closed |
|---|
comment:14 by , 16 years ago
I need #define powf pow #define floorf floor #define fabsf fabs in the sound/softsynth/mt32/partial|tables|synth.cpp files if OS = Solaris..
and since 0.11.0 and the introduction of timidity, I also need the compiler flags -lnsl and -lsocket added for some network routines which that midi driver uses.
comment:15 by , 16 years ago
| Status: | closed → new |
|---|
comment:16 by , 16 years ago
I commited some changes which hopefully fix this issue. Please test with latest trunk and tell me if it helps. Thanks!
comment:17 by , 16 years ago
| Owner: | set to |
|---|
comment:18 by , 16 years ago
| Owner: | changed from to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:19 by , 16 years ago
Well, Solaris 8 builds were coming each version since then, so this bug seems to be just overlooked. Closing as fixed.
comment:20 by , 5 years ago
| Component: | → Ports |
|---|
comment:21 by , 5 years ago
| Component: | Ports → Port: Solaris |
|---|
Hm, I see no patch attached to this patch tracker item.
Please attach a patch implementing the desired functionality, then we can review it for inclusion.