Opened 13 years ago

Closed 11 years ago

Last modified 5 months ago

#2741 closed defect (fixed)

SOLARIS: solaris 8 build broken

Reported by: SF/wooshell Owned by: sev-
Priority: normal Component: Port: Solaris
Keywords: Cc:
Game:

Description

Since the MT32emu was introduced, I'm encountering
compilation errors on Solaris 8, probably to C99
conformity issues.
Basically, I'd need
#ifdef Solaris
#define fabsf fabs
#define fpowf fpow
... and a few other fmathf functions I can't look up at
the moment in the mt32emu/*.c source files.

Changing that by hand for the release binaries is no
problem, but for every svn version I build, it's
annoying.. please fix ;)

I don't know whether the problem still exists on
Solaris 9 or 10, but it does on 8 and below. I don't
know how to detect that circumstance reliably (without
actually checking for the presence of those functions),
but applying the #define on all Solarises shouldn't
cause any problems as those functions produce floats
anyway, even the versions without -f.

Ticket imported from: #1523129. Ticket imported from: bugs/2741.

Change History (21)

comment:1 Changed 13 years ago by SF/wooshell

Summary: small fix neede for solaris 8 buildsmall fix needed for solaris 8 build

comment:2 Changed 13 years ago by fingolfin

Hm, I see no patch attached to this patch tracker item.

Please attach a patch implementing the desired functionality, then we can review
it for inclusion.

comment:3 Changed 13 years ago by fingolfin

Status: newpending

comment:4 Changed 13 years ago by SF/sf-robot

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

comment:5 Changed 13 years ago by SF/sf-robot

Status: pendingclosed

comment:6 Changed 13 years ago by SF/wooshell

If I had been able to produce a valid patch, I would already
have sent it to someone on IRC for submission instead of
bothering with the patch tracker here.
I have clearly outlined what patch I need for my special
case, for someone better skilled to come up with the
implementation.
Considering that the "problem" is neither a feature request
nor a bug report, I was pointed here to request a patch.

comment:7 Changed 13 years ago by SF/wooshell

Status: closedpending

comment:8 Changed 13 years ago by fingolfin

A patch tracker is there for submitting patches. Not for requesting them.

So, as I understand it, you are requesting that a certain issue ("bug") which
affects you (namely that building on Solaris 8 is broken) gets fixed by
"someone". Hence this is a bug report, moving to the appropriate tracker.

BTW, we are using C++, so C99 isn't relevant.

comment:9 Changed 13 years ago by fingolfin

Status: pendingnew
Summary: small fix needed for solaris 8 buildSOLARIS: solaris 8 build broken

comment:10 Changed 13 years ago by fingolfin

Status: newpending

comment:11 Changed 13 years ago by fingolfin

If you tell us what error(s) you get, precisely, we could try to implement a fix...
I.e. which functions are "missing" ?

comment:12 Changed 13 years ago by SF/sf-robot

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

comment:13 Changed 13 years ago by SF/sf-robot

Status: pendingclosed

comment:14 Changed 11 years ago by SF/wooshell

I need
#define powf pow
#define floorf floor
#define fabsf fabs
in the sound/softsynth/mt32/partial|tables|synth.cpp files if OS = Solaris..

and since 0.11.0 and the introduction of timidity, I also need the compiler flags -lnsl and -lsocket added for some network routines which that midi driver uses.

comment:15 Changed 11 years ago by SF/wooshell

Status: closednew

comment:16 Changed 11 years ago by fingolfin

I commited some changes which hopefully fix this issue. Please test with latest trunk and tell me if it helps. Thanks!

comment:17 Changed 11 years ago by fingolfin

Owner: set to fingolfin

comment:18 Changed 11 years ago by sev-

Owner: changed from fingolfin to sev-
Resolution: fixed
Status: newclosed

comment:19 Changed 11 years ago by sev-

Well, Solaris 8 builds were coming each version since then, so this bug seems to be just overlooked. Closing as fixed.

comment:20 Changed 6 months ago by digitall

Component: Ports

comment:21 Changed 5 months ago by digitall

Component: PortsPort: Solaris
Note: See TracTickets for help on using tickets.