Opened 17 years ago
Closed 17 years ago
Last modified 4 years ago
#2638 closed defect (fixed)
GUI: trying to enter empty CD drive
|Reported by:||SF/clemty||Owned by:||cyxx|
SVN May 30 Win32
trying to add a game on another drive I moved up till I got the drive letter "directories", tried to enter K: which is my (empty) DVD drive
now K:\ appears in the heading, implying that I successfully entered that directory, even though I still get the list of drive letters
maybe only print the current directory if ScummVM actually managed to enter it?
Ticket imported from: #1497725. Ticket imported from: bugs/2638.
Change History (7)
comment:1 by , 17 years ago
comment:2 by , 17 years ago
by , 17 years ago
comment:3 by , 17 years ago
Looks like there's a problem in the BrowserDialog class.
The return code of FilesystemNode::listDir isn't checked at all. In this case, the FSList passed as the argument isn't cleared and the BrowserClass redraws the file list with the contents of the previous result of listDir.
Not sure what is the best solution : - always clear the FSList in FilesystemNode::listDir(), even in case of failure - adapt the BrowserDialog class to disable browsing to the 'bad directory' (ie. don't do any graphics update) - adapt the BrowserDialog class to check the return value and draw a empty list (like it was in version 0.8.2) (*)
Patch attached - third solution (*)
comment:4 by , 17 years ago
comment:5 by , 17 years ago
|Status:||new → closed|
comment:6 by , 4 years ago
|Component:||--Unset-- → GUI|
We do not actually change the current directory when browsing files... This sounds more like a flaw in the windows FSNode code...