Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#2539 closed defect (fixed)

COMI: Verb strings aren't wrapped

Reported by: lordhoto Owned by: cyxx
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Monkey Island 3

Description

Hi,

I played COMI (German version) with a SVN checkout from 16.03.2006 on linux (x86). Sometimes if the texts while talking to somebody are missing the linebreaks that's why it's impossibe to read all of the text. Screenshot included.

Ticket imported from: #1452272. Ticket imported from: bugs/2539.

Attachments (7)

comi-textbug.png (178.2 KB ) - added by lordhoto 14 years ago.
screenshot
comi.s02 (66.2 KB ) - added by lordhoto 14 years ago.
savegame
verbs.txt (3.2 KB ) - added by Kirben 14 years ago.
Patch for issue
1452272.diff (3.3 KB ) - added by cyxx 14 years ago.
Patch for issue v2 (svn 29th May 2006)
comi-french-wrapline-testcase.png (288.9 KB ) - added by cyxx 14 years ago.
Test-case screenshot, patch v2 applied
example.png (203.4 KB ) - added by Kirben 14 years ago.
Example of problem
1452272-2.diff (4.8 KB ) - added by cyxx 14 years ago.
Patch for issue v3 (svn 30th May 2006)

Download all attachments as: .zip

Change History (16)

by lordhoto, 14 years ago

Attachment: comi-textbug.png added

screenshot

by lordhoto, 14 years ago

Attachment: comi.s02 added

savegame

comment:1 by Kirben, 14 years ago

The original game would compare the strings length and screen width in drawVerb(), spliting verb's string into two lines when required. Also the verb line spacing setting was used, when the verb's string was split into two lines.

comment:2 by Kirben, 14 years ago

Summary: COMI: Textselection misses linebreaksCOMI: Verb strings aren't wrapped

comment:3 by Kirben, 14 years ago

Owner: set to Kirben

by Kirben, 14 years ago

Attachment: verbs.txt added

Patch for issue

comment:4 by Kirben, 14 years ago

I added patch to solve the line wrapping problems with verbs, based on code of original game. But the next verb after a line wrap, is often placed on top of the wrapped line, when using patch.

by cyxx, 14 years ago

Attachment: 1452272.diff added

Patch for issue v2 (svn 29th May 2006)

comment:5 by cyxx, 14 years ago

What's wrong exactly with your patch, Kirben ? I modified my datafiles locally to have a test-case and didn't experience any special glitch.

I did some minor changes to that patch, though : - removed the space character at the beginning of the wrapped line - made the check specific to v8 (dig and ft don't seem to handle this) - initialised the _verbLineSpacing to the same value as the original COMI

by cyxx, 14 years ago

Test-case screenshot, patch v2 applied

by Kirben, 14 years ago

Attachment: example.png added

Example of problem

comment:6 by Kirben, 14 years ago

If a verb line is wrapped, the next verb will be placed over the wrapped part of last verb.

I attached an example of the problem from the German version.

comment:7 by cyxx, 14 years ago

Found some possible problems : - o8_getStringWidth() should use the specified charset directly - if we set a new charset in drawVerb(), we should probably restore the previous one.

Updated patch.

by cyxx, 14 years ago

Attachment: 1452272-2.diff added

Patch for issue v3 (svn 30th May 2006)

comment:8 by Kirben, 14 years ago

The verbs are wrapped correctly in German version of COMI now, I commited updated patch to ScummVM SVN.

comment:9 by Kirben, 14 years ago

Owner: changed from Kirben to cyxx
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.