#2511 closed defect (fixed)
SCUMM: SubstResFileNames partial breakage
| Reported by: | fingolfin | Owned by: | sev- |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
My recent changes probably broke parts of the SubstResFileNames system (I can't verify this since I am missing the relevant games).
In particular, maniac1.d64/maniac2.d64 and zak1.d64/zak2.d64 likely aren't correctly supported at this time.
I simply missed that aspect of the SubstResFileNames system when I recently modified it. But I am working on a rewrite, so please bear a few days with me until I have the new system ready :).
But if somebody who has the relevant files (and thus can perform testing) wants to work on this in the meantime, I assume it could easily be fixed by modifying the following lines in scumm.cpp:
} else if ((_game.platform == Common::kPlatformC64) && _substResFileName.winName) { char tmpBuf1[128], tmpBuf2[128]; generateSubstResFileName("00.LFL", tmpBuf1, sizeof(tmpBuf1)); generateSubstResFileName("01.LFL", tmpBuf2, sizeof(tmpBuf2));
_fileHandle = new ScummC64File(tmpBuf1, tmpBuf2, _game.id == GID_MANIAC);
-> there seems to be no important reason to use generateSubstResFileName here, simply hardcoding the relevant *.d64 filenames here should be just fine.
Ticket imported from: #1439279. Ticket imported from: bugs/2511.
Change History (3)
comment:1 by , 18 years ago
comment:2 by , 18 years ago
| Owner: | changed from to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:3 by , 5 years ago
| Component: | → Engine: SCUMM |
|---|
Fixed in SVN.