Opened 15 years ago

Closed 14 years ago

Last modified 21 months ago

#2493 closed defect (fixed)

BS1: Solaris x86 build fails: variable name collision

Reported by: SF/lblume Owned by: fingolfin
Priority: normal Component: Port: Solaris
Keywords: Cc:
Game:

Description

On Solaris 10 x86, SS and DS are defined as macros in /usr/include/sys/regset.h, as well as a buch of other 2 and 3-letter macros.

Since those are used as variable names in ScummVM, it causes errors at build time: sword1/router.cpp:292: error: expected primary-expression before numeric constant sword1/router.cpp:292: error: expected `;' before numeric constant [...more...]

I attached a very simple patch for ScummVM 0.8.2 that renames those variables as SS_, DS_, and so on.

Ticket imported from: #1428261. Ticket imported from: bugs/2493.

Attachments (1)

scummvm-0.8.2_solaris10-x86_variable_names.patch (3.0 KB ) - added by SF/lblume 15 years ago.
Renames variables SS, DS, and similar to SS_, DS_ …

Download all attachments as: .zip

Change History (6)

by SF/lblume, 15 years ago

Renames variables SS, DS, and similar to SS_, DS_ ...

comment:1 by fingolfin, 15 years ago

Owner: set to lavosspawn
Summary: Solaris x86 build fails: variable name collisionBS1: Solaris x86 build fails: variable name collision

comment:2 by fingolfin, 14 years ago

Fixed in SVN (with a different patch). Thanks for reporting this!

comment:3 by fingolfin, 14 years ago

Owner: changed from lavosspawn to fingolfin
Resolution: fixed
Status: newclosed

comment:4 by digitall, 21 months ago

Component: Ports

comment:5 by digitall, 21 months ago

Component: PortsPort: Solaris
Note: See TracTickets for help on using tickets.