Opened 17 years ago

Closed 17 years ago

Last modified 11 months ago

#245 closed defect (fixed)

sound menu: wrong max volumes

Reported by: SF/logicdeluxe Owned by: fingolfin
Priority: normal Component: Audio
Keywords: Cc:
Game:

Description

Built on May 11 2002 00:14:00 win
You can turn up master volume and sfx volume only up to
100. However higher volumes are supported and work well
with command line parameters and in scummvm.ini

Ticket imported from: #555102. Ticket imported from: bugs/245.

Change History (10)

comment:1 by SF/ender, 17 years ago

This is because the menu values are not really max, but are
intended to be percentages.

Do you think the maximum value you can set via the command
line is not as load as the menus 100%? What values do you
believe you should be able to use?

comment:2 by SF/ender, 17 years ago

Owner: set to SF/ender

comment:3 by SF/logicdeluxe, 17 years ago

Readme.txt and scummvm stoud help list 255 for sfx volume.
Giving 255 by command line works fine as well as given it in
scummvm.ini. In fact it is something louder and I get a
better sound quality. There is an auditable better signal to
noise ratio this way. Besides this the sound menu displays
the value in scummvm.ini not a percent value. It might
intended to be percentage values but abviously it is not.
And the master volume is set to 125 as default if there is
no scummvm.ini. This value seems to be the maximum for
master volume. Bigger values (which you can enter in
scummvm.ini) result in malfunctions to me. But 125 works fine.
Master should range from 0 to 125.
Music should range from 0 to 100.
SFX should range from 0 to 255.
This is equivalent to scummvm.ini and command line options,
and it works fine for me. Of course you could also change
the scale in order to fit these ranges in percentage values.

comment:4 by fingolfin, 17 years ago

So what should be done about this? If Endy has no
time/machine, I offer to look into this, if you like..

comment:5 by fingolfin, 17 years ago

Ender? What about this? Do you intend to fix it? If not
re-assign it to me, please. Even though we are working on a
new GUI it can't hurt to fix this in the old one before :-)

Personally I think all the values should be percentages in
the GUI.

comment:6 by SF/ender, 17 years ago

Owner: changed from SF/ender to fingolfin

comment:7 by SF/ender, 17 years ago

Passing the ball, it's all yours :)

comment:8 by fingolfin, 17 years ago

Slider ranges are 0-100, yet the volumes use different ones.
We want to fix this, ideally by simply converting the GUI
value range 0-100 to the 'real' ranges and back (for maximal
backward compatibility). However, this is not easy, in fact
with the current system it is impossible. For a quick
overview, read this:

Music volume range: 1-100
iMUSE master volume range: 0-128
Mixer master volume range: 0-256
SFX volume range: 0-256

Correct, the master volume range of iMUSE and the mixer
don't match! Since both are steered by _sound_volume_master,
we are screwed. This is really a big mess and sadly is not
the only case of similar issues. The almost complete lack of
any documentation (and I am not very demanding, I even count
comments as docs) are not helping us either.

Somebody (me if I have the time) should fix this by
rewriting all the functions to take a nice range like 0-255
or 0-256. And while (s)he is at it, HiFi equipment uses
logarithmic volume controls (not linear ones as we do) since
they match the human ear better.

comment:9 by fingolfin, 17 years ago

Resolution: fixed
Status: newclosed

comment:10 by digitall, 11 months ago

Component: --Unset--Audio
Note: See TracTickets for help on using tickets.