Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#2444 closed defect (fixed)

scummvm-0.8.0-3: array subscript out of range

Reported by: SF/sndirsch Owned by: fingolfin
Priority: normal Component: Tools
Keywords: Cc:
Game:

Description

A customer wrote us:

--- I just tried to compile package scummvm-0.8.0-3 with a non standard version of the GNU C compiler

It said

compress_scumm_bun.cpp:144: warning: array subscript out of range

The source code is

_destImcTable[89] = 0;

but

static byte _destImcTable[89];

Clearly broken code. Suggest code rework. ---

He's talking about the tools package.

Ticket imported from: #1400506. Ticket imported from: bugs/2444.

Change History (3)

comment:1 by fingolfin, 15 years ago

Thanks for pointing this out. It has been fixed in CVS (actually, I synced compress_scumm_bun.cpp with the newer code in dimuse_codecs.cpp, which fixes this as a side effect).

For those who are slightly irritated by this tracker item (I was): According to Google, the bug submitter seems to work for SUSE, and so I guess he's talking about a mail by a customer of SUSE. :-)

comment:2 by fingolfin, 15 years ago

Owner: set to fingolfin
Resolution: fixed
Status: newclosed

comment:3 by SF/sndirsch, 15 years ago

Sorry, I didn't mention it. Yes, it was a customer by SUSE, who reported this bug. I'm happy this has already been fixed in CVS. Thanks for the quick response.

Note: See TracTickets for help on using tickets.