Opened 14 years ago

Closed 14 years ago

Last modified 12 months ago

#2388 closed defect (fixed)

SYMBIAN: S80 installer installs in documents

Reported by: SF/pbrodersen Owned by: anotherguest
Priority: normal Component: Port: Symbian
Keywords: Cc:
Game:

Description

Hi,

I have installed ScummVM 0.8.0 on my Nokia 9500 (S80).
It installed itself in c:\documents instead of checking
system variables for preferred folder. On my Danish
mobile phone the default folder is called c:\Filer
(c:\documents didn't exist before I installed ScummVM).

I wish ScummVM would make use of the system specific
path instead of a supposedly hardcoded path.

- Peter

Ticket imported from: #1368615. Ticket imported from: bugs/2388.

Change History (12)

comment:1 by fingolfin, 14 years ago

Owner: set to anotherguest

comment:2 by anotherguest, 14 years ago

Dont think that this can be detected during install. The
reason for the file creation is because we wanted the
escumm directory to be removed upon uninstall. So where
the "filer" name is coming from I dont know and thus cant
do anything about. Well .. the only thing I can do is to
leave an empty escumm directory in your "filer" directory
upon uninstall, and probably also the INI file.

So what is best, leaving files on uninstall or
using "documents" as a folder?

comment:3 by fingolfin, 14 years ago

Anotherquest, I am confused. Why would you have to leave files when using "c:
\Filer" but not when using "c:\documents" ? Maybe I misunderstand something...
?!?

comment:4 by fingolfin, 14 years ago

Summary: S80 installer installs in documentsSYMBIAN: S80 installer installs in documents

comment:5 by anotherguest, 14 years ago

Hi! Well.. its the installation file which tells where the
files go, and from where they should be uninstalled. If we
remove the documents reference from the installation file
(as "filer" is not known from there"), the uninstallation
dont know where to remove any files.

But we have been working around this, to store the ini file
in the same location as the application folder which should
be good, and also all targets have been renamed ScummVM
instead of EScummVM. So these changes will be coming
shortly. :-)

comment:6 by fingolfin, 14 years ago

I still don't quite understand. Does the following correctly summarize what you
consider to be the problem:
"We could install into c:\filer instead of c:\documents. However, if we did that,
the uninstalller would fail to work, because it hard codes c:\documents" ?

If so, wouldn't it be simply a matter of modifying the uninstaller, too ? Or is the
uninstaller a 3rd party of OS component which you cannot modify?

comment:7 by SF/pbrodersen, 14 years ago

anotherguest: all other smart Symbian apps are using system
variables to check the name of the file folder. It is
nothing different of e.g. Windows where applications use
%APPDATA% and %ProgramFiles% instead of hard coding e.g.
"C:\Program Files". These paths vary on different languages
and they should be allowed to.

I have never had a folder called c:\documents on my S80
device; it was created by EScummVM in the first place (right
before c:\documents\EScummVM was created). The only purpose
of that folder seem to be a place to store scummvm.ini (and
scummvm.stderr and scummvm.stdout).

I think it makes sense to store the ini file at the
application folder. And just to summarize: No system
dependent path should ever be hardcoded in an application.

Just my 0.02kr :)

comment:8 by anotherguest, 14 years ago

Well this is true for applications which
1. Is document based
2. Assumes that the user creates data which should be
persisted and not removed upon uninstallation.
Neither one of these are true for ScummVM and according to
Symbian signed rules all application created data, which
can't be regarded as user data (save games etc) should be
removed upon uninstallation.
And since we placed the ini file in the documents folder,
this was totally wrong, and we have now moved this to the
application folder instead.

And as for uninstallation app, this is a part of the OS, so
unfortunatly we dont have any control over this without
alot of extra fuss.

But the fix we have now will be the right one. :-)

comment:9 by fingolfin, 14 years ago

So, does that mean that the Symbian backend does no longer hardcode "c:
\documents" (which apparently would be plain wrong to do, just like it is wrong
under Windows) ? If that is the case, can this bug be closed?

comment:10 by anotherguest, 14 years ago

Yes, the latest CVS versions are using the application path
instead of a hardcoded path for both the ini file and the
savegames. So I am closing this one.

comment:11 by anotherguest, 14 years ago

Resolution: fixed
Status: newclosed

comment:12 by digitall, 12 months ago

Component: Port: Symbian
Note: See TracTickets for help on using tickets.