Opened 18 years ago

Closed 18 years ago

Last modified 6 years ago

#2387 closed defect

SCUMM: Bad memory access in filename substitution

Reported by: eriktorbjorn Owned by: cyxx
Priority: high Component: Engine: SCUMM
Version: Keywords:
Cc: Game:


This happens in the latest CVS snapshot, at least, and has been happening for a while.

In some cases, the generateSubstResFileName_() is called with 'filename' being an empty string. In this case, it will be accessing filename[-1], which could be bad.

I'm not sure exactly when this happens - I'm filing this just so that Eugene won't forget about it - but I'll give two examples of games where it happens for me:

* Monkey Island 1, data files monkey1.000 and monkey1.001. To run this, I use a "monkey1" target.

* The FM-Towns Fate of Atlantis demo. To run this, I use a "atlantisa" target.

Ticket imported from: #1368343. Ticket imported from: bugs/2387.

Change History (6)

comment:1 by eriktorbjorn, 18 years ago

Owner: set to sev-

comment:2 by eriktorbjorn, 18 years ago

Any news on this?

comment:3 by fingolfin, 18 years ago

Priority: normalhigh

comment:4 by cyxx, 18 years ago

That should be fixed with latest CVS. I also modified/cleaned up a bit generateSubFilename.

comment:5 by cyxx, 18 years ago

Owner: changed from sev- to cyxx
Status: newclosed

comment:6 by digitall, 6 years ago

Component: --Unset--Engine: SCUMM
Note: See TracTickets for help on using tickets.