Opened 15 years ago

Closed 15 years ago

Last modified 2 years ago

#2309 closed defect (fixed)

Scumm: Crash with subtitle function

Reported by: SF/simsaw Owned by: Kirben
Priority: normal Component: GUI
Keywords: Cc:


When you decrease the subtitle to the lowest point and you try to increase it again (the subtitle speed display has to disappear before) ScummVM crashes. It also happens the other way round.

Ticket imported from: #1337498. Ticket imported from: bugs/2309.

Change History (11)

comment:1 by eriktorbjorn, 15 years ago

Looks like a simple mix-up: The first time you hit + the delay value would decrease, and the first time you hit - the value would increase. That's what caused the value to overflow/underflow when the speed display was opened.

I've changed it to be the other way around. Thanks for pointing it out!

comment:2 by eriktorbjorn, 15 years ago

Owner: set to eriktorbjorn
Resolution: fixed
Status: newclosed

comment:3 by cyxx, 15 years ago

Apparently, this was introduced with bug #1335405. As it's written there, the 'talk speed' dialog which is displayed when the user presses '-' or '+' is a bit misleading. With the '-' or '+' keys, the "talkDelay" gets modified. But we display it as "talkSpeed" (which is more or less the opposite).

I am not sure what is the best solution : - change the "talk speed" caption dialog by "talk delay" - or as Kirben did, swap the "_lastKeyHit" conditions - something else ?

comment:4 by eriktorbjorn, 15 years ago

I didn't consider that. All I know is that the old behaviour was completely wrong, because the first keypress would move the gauge in one direction, while subsequent ones would move it in the other direction. Which is what could lead to a failed assertion.

comment:5 by eriktorbjorn, 15 years ago

Status: closednew

comment:6 by eriktorbjorn, 15 years ago

Reopening and assigning to Kirben for further comments, since he seems to have made the change cyx mentioned.

I don't know what the correct behaviour is, but surely a gauge that increases when you press - and decreases when you press + would be extremely confusing...?

comment:7 by eriktorbjorn, 15 years ago

Owner: changed from eriktorbjorn to Kirben
Resolution: fixed

comment:8 by Kirben, 15 years ago

Resolution: fixed
Status: newclosed

comment:9 by Kirben, 15 years ago

We should match the keyboard shortcuts behaviour of the original games, where '-' decreased the subtitle speed and '+' increased the subtitle speed. I changed ScummVM to match the original games again, remembering to adjust the safety checks this time. I renamed 'Talk Speed' to 'Talk Delay' to avoid any confusion about the subtitle speed controls.

comment:10 by Kirben, 15 years ago

For future reference: We used to match the subtitle speed controls of the original games, as our README still states. Fingolfin changed the subtitle speed controls, when he added that GUI dialog.

comment:11 by digitall, 2 years ago

Component: GUI
Note: See TracTickets for help on using tickets.