Opened 14 years ago

Closed 14 years ago

Last modified 13 months ago

#2297 closed defect (fixed)

ITE: Mouse visible where in wrong scenes

Reported by: SF/simsaw Owned by: eriktorbjorn
Priority: normal Component: Engine: SAGA
Keywords: Cc:
Game: Inherit the Earth

Description

In the outro the mouse pointer is still visible and a little
disturbing. It would be very great if that could be fixed
before release version. Thanks!

Bug noticed in German DOS CD version and English
DOS floppy.

Ticket imported from: #1333391. Ticket imported from: bugs/2297.

Attachments (1)

saga-cursor.diff (2.6 KB ) - added by eriktorbjorn 14 years ago.
Patch against an October 21 CVS snapshot

Download all attachments as: .zip

Change History (9)

comment:1 by eriktorbjorn, 14 years ago

The cursor is shown because we almost always send a "show
cursor" event in loadScene().

In addition, a scene may have the kSceneFlagShowCursor flag,
in which case we call Interface::activate(), which also
shows the cursor. Actually, we check this flag twice, which
seems excessive.

It looks like the original had a counter keeping track of
hiding/showing the cursor, so that hiding the cursor twice
meant you had to show it twice for it to actually reappear.
We don't do that, but I don't know if implementing that
would help in this case. Because it seems we show the cursor
more often than we hide it during the end credits...

To summarize, I don't know. Assigning to sev for further
comments/ideas.

comment:2 by eriktorbjorn, 14 years ago

Owner: set to sev-

by eriktorbjorn, 14 years ago

Attachment: saga-cursor.diff added

Patch against an October 21 CVS snapshot

comment:3 by eriktorbjorn, 14 years ago

On a closer look, showing the cursor in loadScene() appears
to be the wrong behaviour, unless the aforementioned
kSceneFlagShowCursor is set.

The attached patch seems to fix the problem. It'll probably
be applied to the CVS trunk shortly, at the very least.
Hopefully to the branch as well, if no one objects to it.
(Not because the bug shouldn't be fixed, but because I may
have gotten it wrong.)

comment:4 by sev-, 14 years ago

Owner: sev- removed

comment:5 by sev-, 14 years ago

Overall your patch looks ok to commit to both branches,

comment:6 by eriktorbjorn, 14 years ago

Owner: set to eriktorbjorn
Resolution: fixed
Status: newclosed

comment:7 by eriktorbjorn, 14 years ago

Ok. Committed. Thanks for checking!

comment:8 by digitall, 13 months ago

Component: Engine: SAGA
Game: Inherit the Earth
Note: See TracTickets for help on using tickets.