Opened 15 years ago

Closed 14 years ago

Last modified 20 months ago

#2213 closed defect

LOOM: spanish version bad line feed

Reported by: SF/vood Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Loom

Description

Well, this is pretty long to explain. Basicly Loom EGA spanish seems to have different behaviours if you compare real msdos version running in dosbox, vs scummvm 7.1 vs scummvm CVS (sept27 05).

I have tested the same files with all and I got the following during Loom´s "concilium":

1 = Last clothos line 2 = Hetchel first close up

1.- dosbox: everything perfect 1.- scummvm7.1: everything perfect 1.- scummvmCVS: an empty text line appears between both text lines

2.- dosbox: everything perfect. Hetchel says "Cloth." 2.- scummvm7.1: Hetchel says "Clotho" 2.- scummvmCVS: Hetchel says "Clotho" and in the next line "s."

(Notice this failures doesnt seem to happen in the english version)

I´ve added screenshots with all those failures.

Ticket imported from: #1306269. Ticket imported from: bugs/2213.

Attachments (2)

bugsloom.rar (133.6 KB ) - added by SF/vood 15 years ago.
Loom Spanish bugs
dumpsloom.rar (45.2 KB ) - added by SF/vood 15 years ago.
Loom spanish bad line feed dump

Download all attachments as: .zip

Change History (20)

by SF/vood, 15 years ago

Attachment: bugsloom.rar added

Loom Spanish bugs

comment:1 by Kirben, 15 years ago

It would help if you could provide a dump of the scripts used at those locations:

1. Create a 'dumps' directory, in the directory where ScummVM is located. 2. Start ScummVM from the command line, with the dump scripts option: ie scummvm -u loom 3. Start a fresh game. 4. Play game, until just after Hetchel hatched out of egg. 5. Compress and attached the *.dmp files in the 'dumps' directory.

by SF/vood, 15 years ago

Attachment: dumpsloom.rar added

Loom spanish bad line feed dump

comment:2 by SF/vood, 15 years ago

Ok, I played the game til you get Bobbins control again after hetchel egg conversion.

Heres the dump

comment:3 by Kirben, 15 years ago

Owner: set to Kirben

comment:4 by Kirben, 15 years ago

Please try the next ScummVM daily snapshot and see if the issues still occur.

comment:5 by SF/vood, 15 years ago

Now the line feeding works perfect, but the other bug shows exactly the same as 7.1 version

comment:6 by fingolfin, 15 years ago

vood, could you be a bit more specific? Which of the bugs you listed is gone, which is fixed? Or, even better, could you simply re-state which problem is still present?

comment:7 by Kirben, 15 years ago

The 2nd issue still occurs, with 'Clotho' continuing onto the next line, with an 's.'.

Judging by screenshots, the original version would never automatically go onto next line. Instead it would keep re- printing the last character on the right edge of the screen, until the string was complete.

comment:8 by fingolfin, 15 years ago

Hm, OK. It should be rather simple to implement that. The question is, though: For which games should this change be done? Only for LoomEGA, or are there others... ? If we change too many games in this way, we'll certainly introduce regressions...

Though in this particular case, the problem really is that the text there was not wrapped correctly by the translators... <sigh>

comment:9 by Kirben, 14 years ago

I think it would be best to limit the change to SCUMM 3 games only. See 'Handle line overflow for V3' section of CHARSET_1() for my failed attempt, which can be replaced.

comment:10 by Kirben, 14 years ago

Owner: Kirben removed

comment:11 by fingolfin, 14 years ago

Owner: set to fingolfin

comment:12 by fingolfin, 14 years ago

I'll take a look at this issue during the weekend (but if somebody beats me to it, I won't mind ;-).

comment:13 by fingolfin, 14 years ago

I just made some changes to the relevant code. The bug won't be fixed by this, but I'd be interested to know if any regressions occured... so if somebody could try again with latest SVN and tell me (for both of the issues mentioned in the original report) what their status is (and whether anything changed, i.e. if the brokeness now is different)...

comment:14 by fingolfin, 14 years ago

This tracker item is pending response by the submitter; we cannot continue processing it before that happens. As a consequence, its status has been set to "Pending". It will automatically revert to "Open" once a new comment is made to this item. If no response is made within 14 days, it will automatically be closed.

Thank you.

comment:15 by fingolfin, 14 years ago

Status: newpending

comment:16 by SF/sf-robot, 14 years ago

Status: pendingclosed

comment:17 by SF/sf-robot, 14 years ago

This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker).

comment:18 by digitall, 20 months ago

Component: Engine: SCUMM
Game: Loom
Summary: LOOM: spanish version bad line feed LOOM: spanish version bad line feed
Note: See TracTickets for help on using tickets.