Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#2111 closed defect (fixed)

ZAK: Screen not fully redrawn after loading savegame

Reported by: eriktorbjorn Owned by: cyxx
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Zak McKracken

Description

Latest ScummVM CVS snapshot
Zak McKracken, English V2 Enhanced version

When loading the attached savegames the screen isn't
completely redrawn. I can't understand why, because the
very act of loading a savegame should trigger a full
redraw.

Ticket imported from: #1252714. Ticket imported from: bugs/2111.

Attachments (3)

zak.s30 (6.8 KB ) - added by eriktorbjorn 14 years ago.
Savegame on the airplane
zak.s02 (7.1 KB ) - added by eriktorbjorn 14 years ago.
Another savegame on the airplane
valgrind.txt (12.6 KB ) - added by Kirben 14 years ago.
Valgrind log

Download all attachments as: .zip

Change History (9)

by eriktorbjorn, 14 years ago

Attachment: zak.s30 added

Savegame on the airplane

by eriktorbjorn, 14 years ago

Attachment: zak.s02 added

Another savegame on the airplane

by Kirben, 14 years ago

Attachment: valgrind.txt added

Valgrind log

comment:1 by Kirben, 14 years ago

When switching between the two saved game I noticed crashes
under Windows, due to memory corruption. I have attached a
valgrind log, with reports a few memory read/write issues.

comment:2 by SF/sascha_silbe, 14 years ago

FWIW: The missing redraw happens with the V1 game (english), too. But only the CVS version (20050731), not the 0.7.1 release.
OS: Linux

comment:3 by cyxx, 14 years ago

It seems these savegames contains an actor with a 'top'
coordinate equals to -1 (not sure if this is valid). When
redrawing the actor background, this coordinate will be
passed as the argument to Gdi::resetBackground, so I just
added some clipping in it to prevent crashes (as we do for
bottom).

comment:4 by SF/sascha_silbe, 14 years ago

The latest CVS version fixes it at least for the case I've seen (i.e. inside the plane).

comment:5 by Kirben, 14 years ago

Resolution: fixed
Status: newclosed

comment:6 by Kirben, 14 years ago

Owner: set to cyxx
Note: See TracTickets for help on using tickets.