Opened 15 years ago

Closed 14 years ago

Last modified 21 months ago

#2083 closed defect (fixed)

MIDI: SysEx API is not used consistently

Reported by: fingolfin Owned by: fingolfin
Priority: normal Component: Audio: MT32
Keywords: Cc:
Game:

Description

Our MidiDriver::sysEx() method is not used consistently; I guess that's partially because it's not really clearly documented (we should fix that, once we have determined *what* it should do, precisely :-).

Right now, most of our MidiDrivers (but not all) expect sysEx() to receive sysEx data w/o the leading 0xF0 and the trailing 0xF7.

Some of the client code complies to that; but there are other places where we call sysEx with data which already includes the 0xF0 / 0xF7.

So, we should decide which behaviour we prefer. Once we have done that, we should fix all MidiDrivers and all places where sysEx() is called to comply to that specification. And of course it should also be documented in a doxygen commen in mididriver.h!

Ticket imported from: #1231434. Ticket imported from: bugs/2083.

Change History (5)

comment:1 by fingolfin, 14 years ago

Hi Jamieson630... since you've apparently had some time for ScummVM recently, maybe you are interested in taking a look at this issue...?

comment:2 by fingolfin, 14 years ago

Owner: set to SF/jamieson630

comment:3 by fingolfin, 14 years ago

Owner: SF/jamieson630 removed

comment:4 by fingolfin, 14 years ago

Owner: set to fingolfin
Resolution: fixed
Status: newclosed

comment:5 by digitall, 21 months ago

Component: --Unset--Audio: MT32
Note: See TracTickets for help on using tickets.