Opened 14 years ago

Closed 14 years ago

Last modified 10 months ago

#2061 closed defect (wontfix)

SAGA: run-length slice typo in online source

Reported by: SF/bilight52 Owned by: sev-
Priority: normal Component: Engine: SAGA
Keywords: Cc:
Game:

Description

this may be totally old but it tripped me up:

if (dx >= dy) {

min_run = dx / dy;
error_up = (dx % dy) * 2;
error_down = dy * 2;
error = (dx % dy) - (dy * 2);
init_run = (min_run / 2) + 1; // ALSO DO THIS.. min_run>>1+1
end_run = init_run;

if ((error_up == 0) && (min_run & 0x01) == 0) {
init_run--;
}

//////// error += dy; ///////// typo?error
//corrected code according to abrash

if ((min_run & 0x01) != 0) {
error += dy;
}

//////////////////////////////////
this code is the xmajor section of the run-length slice routine
adapted from abrash. The bug often offsets the line by 1x-pixel.
the code 'error += dy' should read as above.

thanks-cNewman

Ticket imported from: #1216439. Ticket imported from: bugs/2061.

Change History (8)

comment:1 by sev-, 14 years ago

Summary: run-length slice typo in online sourceSAGA: run-length slice typo in online source

comment:2 by sev-, 14 years ago

online source isn't enough to locate it :).

it belongs to saga/gfx.cpp

comment:3 by fingolfin, 14 years ago

Owner: set to sev-
Status: newpending

comment:4 by fingolfin, 14 years ago

I don't understand this "bug report".

First off, what is the "bug" being reported?

Secondly, what is that code fragment meant to be? Some kind of weird
patch? Why isn't it in proper patch format than, and why not on a patch
tracker item?

Or is this more a question about what some kind of code is meant to do?

comment:5 by sev-, 14 years ago

Thanks for reporting. Though form of your report is really
unusial :)

I'm closing this report but I didn't fix it according to
your instructions. This report just reminded me that I
planned to remove saga engine implementation of line drawing
routine in favor of ScummVM's implementation, so I went and
zapped whole routine as it was just a code duplication.

comment:6 by sev-, 14 years ago

Resolution: wontfix
Status: pendingclosed

comment:7 by SF/bilight52, 14 years ago

The above typo,error,bug is in scummvm-0.7.1 => saga => gfx.cpp line #
663. The bug is that it shifts xmajor lines by 1 pixel if always done.

I am not familiar with your system and also sent a message directly to
sev. Sorry to be of trouble

cNewman

comment:8 by digitall, 10 months ago

Component: Engine: SAGA
Note: See TracTickets for help on using tickets.