#1953 closed defect
BASS: Hanging notes fix / patch
| Reported by: | SF/tbcarey | Owned by: | sev- |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Sky |
| Version: | Keywords: | ||
| Cc: | Game: | Beneath a Steel Sky |
Description
Sorry, here's a follow-up patch for BASS to fix the hanging notes observed when using any external synth [MT-32 or GMIDI]. The previous patch should, theoretically, fix the problem for GM devices. However, I discovered that ~GmMusic was never being called because the only thing that happens when BASS exits is that Control::showGameQuitMsg() is called, which then sends an OSystem::quit(). Therefore I have created this temporary fix until quite a bit of BASS' code is re-written.
I only did a plain diff because, being the cvs novice I am, I could not get cvs diff to work properly. Sorry.
Ticket imported from: #1162546. Ticket imported from: bugs/1953.
Attachments (1)
Change History (7)
comment:1 by , 19 years ago
by , 19 years ago
comment:2 by , 19 years ago
Woo-hoo! After much delay and agony, here's the patch. Thanks for the help.
comment:3 by , 19 years ago
| Status: | new → closed |
|---|
comment:4 by , 19 years ago
| Owner: | set to |
|---|
comment:5 by , 19 years ago
Commited. Thanks a lot.
May you, please, consult http://www.scummvm.org/documentation.php?view=conventions
Particularly set your tab with to 4.
comment:6 by , 19 years ago
| Component: | → Engine: Sky |
|---|---|
| Game: | → Beneath a Steel Sky |
Commands are these:
cd your_scumm_directory cvs -z3 diff -u >your.patch
and attach resulting your.patch. Maybe browse it before that and remove all unnecesaary debug output or uncommited files designed by leading '?'