Opened 14 years ago

Closed 14 years ago

Last modified 10 months ago

#1950 closed defect (fixed)

ALL: gfx-mode in command line will ignore -f option

Reported by: SF/uweryssel Owned by: fingolfin
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

ScummVM version 0.7.0

If gfxmode and fullscreen options are set in command line
and -f is set after -g..., the fullscreen option will be ignored.

So
"scummvm -f -g<gfx-mode>"
doesn't work and
"scummvm -g<gfx-mode> -f"
works.
(replace <gfx-mode> with your favourite gfx-mode, not normal or default)

I've found the bug in gamedetector.cpp and sdl.cpp.
Those actions are done in GameDetector::parseCommandLine
if options are -f -g...:

1. parsing of -g option (options parsed backwards)

which means:

- create backend instance (wasn't created yet)
- backend constructor reads fullscreen config value

2. parsing of -f option

Now it's to late to update fullscreen config value,
"fullscreen" won't be checked from backend again.

This bug concerns all options which set
in backend constructors and set before -g option.
In SDL backend they're "joystick_num", "use_GDI",
"fullscreen" and "aspect_ratio".

Ticket imported from: #1160977. Ticket imported from: bugs/1950.

Change History (4)

comment:1 Changed 14 years ago by fingolfin

Summary: gfx-mode in command line will ignore -f optionALL: gfx-mode in command line will ignore -f option

comment:2 Changed 14 years ago by fingolfin

Owner: set to fingolfin
Resolution: fixed
Status: newclosed

comment:3 Changed 14 years ago by fingolfin

Fixed in CVS.

comment:4 Changed 10 months ago by digitall

Component: --Unset----Other--
Note: See TracTickets for help on using tickets.