#1785 closed defect (fixed)
ALL: Transition FX not working anymore
| Reported by: | fingolfin | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | high | Component: | Graphics |
| Version: | Keywords: | ||
| Cc: | Game: | The Dig |
Description
I just noticed that most (all?) of the graphic transitions (opening/ closing iris etc.) stopped working in latest CVS. I confirmed this in The Dig and Monkey Island I, but I guess other are affected, too.
My guess is that I broke this during my recent smooth scrolling changes, though I dunno how I may have pulled that feat ;-). And maybe I am wrong, and something else is responsible, so watch out...
I am too tired to look into this myself now -- everybody feel free to have a go at this one :-)
Ticket imported from: #1035184. Ticket imported from: bugs/1785.
Change History (6)
comment:1 by , 20 years ago
comment:3 by , 20 years ago
I'm getting the impression that something is causing the screen to be redrawn all at once before the transition effect gets to do it gradually. I tried modifying the drawStripToScreen() function to draw random data to the screen instead, and then I could see something at least vaguely transition-effectish.
However, just like with Maniac Mansion, the center point seemed to be wrong, so there may be two different bugs here. I haven't managed to figure out any of them yet, though.
comment:4 by , 20 years ago
Found it. From gfx.cpp:
if (width > vs->w - x); width = vs->w - x;
count the semicolons :-)
comment:5 by , 20 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:6 by , 5 years ago
| Component: | --Unset-- → Graphics |
|---|---|
| Game: | → The Dig |
Some of the transitions work. The scroll effect seems to work - at least with one of my old savegames - and the iris effect is sort-of working in Maniac Mansion, but the center point seems to be off.
But there are plenty of other regressions. I've already filed a bug report about the MM v1 intro, and I just noticed that the DOTT inventory isn't drawn! I'll file a bug report about that right away.