Opened 17 years ago

Closed 17 years ago

Last modified 16 years ago

#1742 closed defect (fixed)

Pitchbend is not reset between tunes

Reported by: eriktorbjorn Owned by: eriktorbjorn
Priority: normal Component: Engine: Sky
Version: Keywords:
Cc: Game: Beneath a Steel Sky

Description

While trying to reproduce the gardener bug (#786482), I happened to notice that if you walk out of Mrs Piermont's apartment at the wrong moment, the next piece of music will sound horribly out of tune.

I think this is because I walked out in the middle of a pitch-bent note (the one after about 35 seconds is a good test case), so at least one channel still had the wrong pitch when the next tune started.

I know the SCUMM engine's iMUSE player used to have a similar problem.

Ticket imported from: #1016556. Ticket imported from: bugs/1742.

Attachments (1)

SKY-VM.002 (14.0 KB ) - added by eriktorbjorn 17 years ago.
Savegame in Mrs Piermont's apartment

Download all attachments as: .zip

Change History (5)

by eriktorbjorn, 17 years ago

Attachment: SKY-VM.002 added

Savegame in Mrs Piermont's apartment

comment:1 by eriktorbjorn, 17 years ago

Status: newclosed

comment:2 by eriktorbjorn, 17 years ago

Owner: set to eriktorbjorn
Resolution: fixed

comment:3 by eriktorbjorn, 17 years ago

I've added a "Pitch Wheel" message to GmChannel::stopNote(), which seems to fix it. Hopefully without causing any regressions.

I don't think the error happens with Adlib.

comment:4 by fingolfin, 16 years ago

Component: Engine: Sky
Game: Beneath a Steel Sky
Note: See TracTickets for help on using tickets.