Opened 16 years ago

Closed 16 years ago

Last modified 7 months ago

#1695 closed defect

ALL: Fullscreen/window switching - Return != Enter

Reported by: SF/swanson Owned by: fingolfin
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

The SDL standard for switching between fullscreen and windowed mode is Alt-Enter as documented in the README. However ScummVM actually uses Return, not the normal keypad Enter key.

In backends/sdl/events.cpp the following line should be changed from;

if (b == KBD_ALT && ev.key.keysym.sym == SDLK_RETURN) {

To;

if (b == KBD_ALT && ev.key.keysym.sym == SDLK_KP_ENTER) {

Or alternatively;

if (b == KBD_ALT && (ev.key.keysym.sym == SDLK_KP_ENTER || ev.key.keysym.sym == SDLK_KP_ENTER)) {

Same in the backends/wince directory.

Ticket imported from: #1001126. Ticket imported from: bugs/1695.

Change History (5)

comment:1 by SF/swanson, 16 years ago

To clarify, I've always used Alt-KP_Enter with Loki games. Using left thumb for ALT and shifting the right thumb from mouse to KP_ENTER, as less movement required ;-)

Make this an RFE to use either RETURN or KP_ENTER as per the second alternative.

comment:2 by fingolfin, 16 years ago

Ah. I already wondered why "Alt-Enter" is a "standard", that was new to me. :-) Though googling for it reveals a lot of programs using it for that purpose -- wow, never knew.

So we should indeed do it the second way: People are used to Alt-Return by now, adding Alt-Enter as an additional possibility won't hurt, IMO.

comment:3 by fingolfin, 16 years ago

Owner: set to fingolfin
Status: newclosed

comment:4 by digitall, 17 months ago

Component: --Other--

comment:5 by GitHub <noreply@…>, 7 months ago

Last edited 7 months ago by criezy (previous) (diff)
Note: See TracTickets for help on using tickets.