Opened 16 years ago

Closed 16 years ago

Last modified 19 months ago

#1686 closed defect (fixed)

CD: Music continues when leaving a room after loading a save

Reported by: SF/mbandsmer Owned by: eriktorbjorn
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Monkey Island 1

Description

After loading a saved game in a room that has a background soundtrack, when you leave the room, IF the room you are entering doesn't have a background soundtrack, the soundtrack from the previous room continues playing.

E.g. Monkey1 CD version: Go into the voodoo lady's shop and save the game. Reload the saved game and leave the shop. The "voodoo" music will continue to play when you are on the street.

Not a big deal, but it's a little annoying.

Ticket imported from: #998276. Ticket imported from: bugs/1686.

Change History (6)

comment:1 by eriktorbjorn, 16 years ago

Hmm... Apparently we save enough of the CD player state to restore looping CD music when loading a game, but we don't save _currentCDSound, so stopSound() doesn't realize when it should stop the CD.

comment:2 by fingolfin, 16 years ago

Owner: set to eriktorbjorn
Summary: Music continues when leaving a room after loading a saved gmCD: Music continues when leaving a room after loading a save

comment:3 by fingolfin, 16 years ago

Erik has a patch for this on the patch tracker. I haven't looked into the issue at all, so i dunno whether it's "good or bad", but then I fully trust erik to make that decision on his own :-). Go ahead and apply that patch if you believe that is the right thing to do, erik!

comment:4 by eriktorbjorn, 16 years ago

I don't know when I'll have the time. I've been away for a week - which means I'm currently drowning in spam - and I'm still on vacation for another week.

comment:5 by Kirben, 16 years ago

Resolution: fixed
Status: newclosed

comment:6 by digitall, 19 months ago

Component: Engine: SCUMM
Game: Monkey Island 1
Note: See TracTickets for help on using tickets.