Simon2 Mac is recognized as Amiga version; if platform is corrected manually then displayed as DOS version

[Eli0rZeR70]

Game files were extracted using the ScummVM dumper companion from a toast image of the Macintosh CD version. Used daily build April 25th Windows 64bit.

User picked target 'simon2-cd-amiga-1' (engine ID 'agos', game ID 'simon2')...
Running Simon the Sorcerer II: The Lion, the Wizard and the Wardrobe (Amiga CD - Update 5/Amiga/English)
gsptr30: 608e277904d87dd28725fa08eacc2c0d, 58652 bytes.
icon.dat: 72096a62d36e6034ea9fecc13b2dbdab, 18089 bytes.
simon2.german: 011bb9cb526bf30a11f3b1fd3b6682fe, 213383 bytes.
simon2.gme: e749c4c103d7e7d51b34620ed76c5a04, 20046789 bytes.
stripped.txt: e229f84d46fa83f99b4a7115679f3fb6, 171 bytes.
tbllist: 2082f8d02075e590300478853a91ffd9, 513 bytes.
MT32: Using 10 chunks, chunk size: 480 frames, buffer size: 4800 frames.

FUNNY THING is if you return to the launcher and correct the platform manually to Macintosh:

User picked target 'simon2-cd-amiga-1' (engine ID 'agos', game ID 'simon2')...
Running Simon the Sorcerer II: The Lion, the Wizard and the Wardrobe (CD/DOS)
gsptr30: 608e277904d87dd28725fa08eacc2c0d, 58652 bytes.
icon.dat: 72096a62d36e6034ea9fecc13b2dbdab, 18089 bytes.
simon2.gme: e749c4c103d7e7d51b34620ed76c5a04, 20046789 bytes.
stripped.txt: e229f84d46fa83f99b4a7115679f3fb6, 171 bytes.
tbllist: 2082f8d02075e590300478853a91ffd9, 513 bytes.

[Eli0rZeR70]

faulty platform recognition when adding the game

[robertmegone]

This is because the Mac and Amiga release use the exact same base data as the DOS version.

I added Amiga detection entries for both the original release and the Update 5 version, since these can be identified via their language files. However, the Amiga CD (Update 5) and the Mac release use identical data files, so they cannot be distinguished this way.

Manually setting the platform to Mac may cause issues, as ScummVM must handle music (and some other systems) the same way it does for the DOS version.

[robertmegone]

After discussion, I'm going switch the game to use kPlatformUnknown and specify "Mac/Amiga" in the extras.

Assigning to myself.

[robertmegone]

@Eli0rZeR70, I've submitted a pull request that resolves this. Once it's merged it will be in the following daily build. I recommend removing the game from ScummVM and re-adding it.

It will now detect with unknown platform, but ScummVM will show 'Mac/Amiga(Update 5)' in the GUI.

[Robert Megone <robert.megone@…>]

In 116d29c7:

AGOS: SIMON2: Correctly detect Mac/Amiga Simon2. Fixes bug #16705