SCI: SQ3 Russian fan translation crashes building menu

[Igoreshazhu]

The game in 'retro\' seems to be an unknown game variant.

Please report the following data to the ScummVM team at https://bugs.scummvm.org/ along with the name of the game you tried to add and its version, language, etc.:

Matched game IDs for the sci engine: sq3-fallback

{"resource.001", 0, "b62b0f98ff876304a5af214c9557f266", 1674902},
{"resource.map", 0, "7f1a45f497a8b93dce14147807ce383c", 3726},

This is russian translation of Space Quest III by Igor Malyshko. Crashes at the startup.

[sluicebox]

The game errors at startup when building the menu. The third kAddMenu call passes a menu string with two consecutive backtick characters, that fails our validation and we error with "multiple right-aligned markers within one menu-item". I don't know the menu string format off the top of my head, but this doesn't seem to be a fatal error in SSCI. If I change the error to a warning the game runs.

We'd have to look into into what the menu string is trying to do and whether our parser should be adjusted to tolerate it. We could also just patch the menu string with a small script patch; we've done that before to handle a fan game.

[sluicebox <22204938+sluicebox@…>]

In 138a266d:

SCI: Reduce kAddMenu validation from error to warning

The SQ3 Russian fan translation has a menu item string with two
consecutive ` characters. This is incorrect, but it didn't cause
a problem in Sierra's interpreter. Reducing our validation to
a warning allows the game to run with expected menu behavior.

Fixes bug #16642

[sluicebox]

Thanks, this game is now detected and doesn't crash.

Detection added in: da6efd519b4e2adfba0f7f783613dc72a232f289

Crash fixed in: 138a266d6ec24a18aa1b67750b99b7ae88f853cb