Opened 3 months ago

Closed 7 weeks ago

Last modified 7 weeks ago

#16594 closed defect (fixed)

VORBIS: seek callback returns stream position instead of 0 or -1

Reported by: flipkick Owned by: flipkick
Priority: low Component: Audio
Version: Keywords: seek
Cc: Game:

Description

The vorbis seek callback is returning the current byte offset instead of seek-style status code.

It should report success or failure, but currently it returns the stream position after the seek. That means failed seeks may be misreported as successful unless the stream position returns -1 and it doesn't follow the callback contract.

This can lead to problems when seeks in vorbis audio fail.

See https://xiph.org/vorbis/doc/vorbisfile/callbacks.html

Change History (4)

comment:1 by flipkick, 3 months ago

Owner: set to flipkick
Resolution: pending
Status: newpending

comment:2 by bluegr, 3 months ago

Resolution: pendingfixed

comment:3 by lephilousophe, 7 weeks ago

Status: pendingclosed

comment:4 by lephilousophe, 7 weeks ago

Bug has been fixed in PR #7302

Note: See TracTickets for help on using tickets.