Opened 9 days ago
Last modified 8 days ago
#16580 pending defect (fixed)
SHERLOCK: ROSETATTOO: Game breaks when in Phrenologist's Studio
| Reported by: | paradroid76-maker | Owned by: | antoniou79 |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Sherlock |
| Version: | Keywords: | Sherlock | |
| Cc: | Game: | Sherlock Holmes: Case of the Rose Tattoo |
Description
Game breaks when in Phrenologist's Studio.
If you show Mycroft's Summary, Blackmail note, or the Envelope to Rose, the game breaks.
Using Scummvm 2026.1.0
Attachments (1)
Change History (5)
by , 9 days ago
| Attachment: | rosetattoo.006 added |
|---|
comment:1 by , 9 days ago
| Keywords: | Sherlock added |
|---|---|
| Summary: | THE LOST FILES OF SHERLOCK HOLMES: CASE OF THE ROSE TATTOO → THE LOST FILES OF SHERLOCK HOLMES: CASE OF THE ROSE TATTOO Game breaks when in Phrenologist's Studio. |
comment:2 by , 8 days ago
| Component: | --Unset-- → Engine: Sherlock |
|---|---|
| Game: | → Sherlock Holmes: Case of the Rose Tattoo |
| Summary: | THE LOST FILES OF SHERLOCK HOLMES: CASE OF THE ROSE TATTOO Game breaks when in Phrenologist's Studio. → SHERLOCK: ROSETATTOO: Game breaks when in Phrenologist's Studio |
comment:3 by , 8 days ago
comment:4 by , 8 days ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → pending |
This is caused by a bug in the sherlock\tattoo\widget_inventory.cpp code for the text tooltip line splitting, which would not set a valid height for the surface, leaving it at 0.
The bug was that the code was attempting to split the tooltip text at a trailing space, which some of the tooltips do have, but this special case was not anticipated by the code logic, so the height for the surface was never set to a valid value, and instead kept its initial 0 value. Thus, the code would throw an assertion fault later on (at https://github.com/scummvm/scummvm/blob/d2c9a9df4888e112dcc1f4822d962747f7c90783/graphics/surface.h?plain=1#L187)
This should be fixed by commit:
https://github.com/scummvm/scummvm/commit/15c477d631ff8dac78368b21d61831746b4c4a37
Please test starting with tomorrow's daily development build (2026.1.1git) to confirm.
In 15c477d6: