GOB: LIT CD - Phonograph in captain's cabin does not play music

[joshas]

Bug details:
In act 3, after setting up phonograph and clicking "start button" ADL music track should start playing, as it does in floppy version, but in CD version all other background music stops and no audio track is played.

Original game in DOSBox has exactly the same issue: no music, but after applying patch (​https://archive.org/details/LITCD_ZIP) phonograph music starts working.
This is very peculiar situation, as game developers probably did not bother remastering phonograph record music in CD audio, and kept ADL track. But due to some unknown circumstances, game was shipped with a bug, where ADL player was disabled in CD version. And ScummVM implemented it exactly as it was. Very likely, that not many players cared about that music track and probably no one bothered to install patch and see what it does, especially while readme states "This patch will fix problems that occur in conjunction with certain
sound cards and CD ROM drives.", nothing about fixes.

I wonder, what approach should be taken to fix this issue in ScummVM? One, very naive solution comes to mind: add both flags "kFeaturesCD | kFeaturesAdLib" to detection file. I tested this very briefly and it seems to work. But, I did not test whole game - this might break something else. And it might be possible, that some other changes were introduced by the patch. Patch only makes changes to game executable, not any of the resource files, so it cannot be used by ScummVM.

ScummVM version: 2.9.1 (stable), also tested in latest master build from git.
Game language: English
Game version: CD
Platform and Compiler: Linux

In attached saved game click "Phonograph" and then click "The start button" hotspot. In current version of ScummVM there should be no audible music after that action. In patched version of original game in DOSBox, ADL audio track is played.

[BJNFNE]

If we decide to add those flags we should add them as seperate entries with additional file to detect the CD version properly.

@joshas can you give me the MD5 hash of intro.stk from the detection for the version which cause problems?

[joshas]

It was DOS CD v1.00, USA version. MD5 hash 6263d09e996c1b4e84ef2d650b820e57 .

[BJNFNE]

@joshas Can you reach out to me over Discord i am known there as BJNFNE

I would like to ask you some questions

[joshas]

I apologize, but I don't use Discord. I'll gladly answer all your questions in this thread, if you don't mind.