Opened 16 years ago

Closed 16 years ago

Last modified 15 months ago

#1641 closed defect (fixed)

Assembly versions of HQ2x and HQ3x scalers

Reported by: SF/kaminari Owned by: sev-
Priority: normal Component: Graphics: Scalers
Keywords: Cc:
Game:

Description

Since the recent update of these filters on 2004-05-20 (23:08), some distorsion around the cursor is now clearly noticeable. The graphics right under the cursor are correctly filtered, but just move the cursor slowly and notice how the graphics get slightly distorded in its wake (try it on the game selection screen for example).

It's been happening since scummvmwin32_20040521.exe and later. Works perfectly in previous builds.

Ticket imported from: #961365. Ticket imported from: bugs/1641.

Attachments (1)

hq_asm.diff (7.1 KB ) - added by cyxx 16 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 by eriktorbjorn, 16 years ago

I see this with the Windows snapshot, as well. I'll have to remember to try it on my Linux box at home later, but I would assume the behaviour is the same there.

In this case it is, of course, only rescaling the area of the screen that is affected by the cursor movement. It might just be my imagination, but it looks to me as if it isn't scaling the edges of the image. Could there be some off-by-one error somewhere?

comment:2 by eriktorbjorn, 16 years ago

Owner: set to sev-

comment:3 by eriktorbjorn, 16 years ago

Sorry, I meant "smoothing the edges", not "scaling the edges".

by cyxx, 16 years ago

Attachment: hq_asm.diff added

comment:4 by cyxx, 16 years ago

It seems the assembly versions handles directly the special extremum points (0, 0), (w-1, 0)... to avoid reading out of graphics buffer. This isn't needed as those special cases are directly handled in the SDL backend by allocating extra bytes.

The attached patch simply changes the asm version to act like the C one, ie without checking the special points. Last thing, I didn't tested that much, hence why I prefer posting the patch than directly committing it :)

comment:5 by sev-, 16 years ago

Status: newclosed

comment:6 by sev-, 16 years ago

Patch seems ok to me, so it is applied. Thanks cyx.

comment:7 by sev-, 16 years ago

Resolution: fixed

comment:8 by digitall, 15 months ago

Component: --Unset--Graphics: Scalers
Note: See TracTickets for help on using tickets.