TOON: Cutscene subtitles not working

[danifs25]

Hi,

Cutscene subtitles seem to be working only on the intro. I have subtitles enabled on the ScummVM settings.

Attached save game. Press the red button to activate the cutifier to watch one of cutscenes.

Using 2.9.1

[eriktorbjorn]

The problem seem to be that some (perhaps most?) videos are specified with a full name, and the subtitle player generates the subtitles filename from that. But SUBTITLES.PAK only stores the base name.

It works in the intro, where only the base name (209_1M.SMK, etc.) are used. But for the cutifier, it's ACT2/DUNGEON/201DM.SMK

Well, that can be easily fixed. Something like this, perhaps:

diff --git a/engines/toon/subtitles.cpp b/engines/toon/subtitles.cpp
index 012d6e9a1db..ecce25d05d5 100644
--- a/engines/toon/subtitles.cpp
+++ b/engines/toon/subtitles.cpp
@@ -82,7 +82,7 @@ bool SubtitleRenderer::load(const Common::Path &video) {
        Common::String ext("tss");
        subfile.replace(subfile.size() - ext.size(), ext.size(), ext);
 
-       Common::ScopedPtr<Common::SeekableReadStream> subsStream(_vm->resources()->openFile(video.getParent().appendComponent(subfile)));
+       Common::ScopedPtr<Common::SeekableReadStream> subsStream(_vm->resources()->openFile(Common::Path(subfile)));
        if (subsStream == nullptr) {
                return false;
        }

Problem is, there are some weird characters in some subtitle lines. And I have no idea what that's about. Here's one example:

[eriktorbjorn]

Other than line-breaks (which should obviously be there) I found non-ASCII characters in the following files:

• 201DM.tss
• 201EM.tss
• 203M.tss
• 205M.tss (This one also says "little body", where it should probably be "little buddy".)
• 207M.tss

And if we do re-generate the subtitles to get rid of these, we should also take the time to proof-read them. I've only glanced through them, but I saw these at least:

• 200_1M.tss: "shoot me for that stuff" -> "shoot me full of that stuff"
• 200_2M.tss: "that's sprout" -> "that sprout"
• 200_2M.tss: "??? a special start" -> "an auspicious start"
• 200_2M.tss: "??? fool!" -> "Impudent fool!"
• 201_1M.tss: "your mission" -> "Your mission"
• 201_1M.tss: "I 'm sorry" -> "I'm sorry"
• 201AM.tss: "??? Drew." -> "Golly, Drew."
• 201AM.tss: "This ??? must take" -> Ok, I'm stumped. "This one", perhaps?
• 205M.tss: "matter of time.. Ha ha." -> "matter of time. Ha ha."
• 205M.tss: "little body" -> "little buddy"
• 215_2M.tss: "the ??? of Fluffy's rabbit" -> "The Costello to Fluffy's Abbott"

[eriktorbjorn]

Some more proof-reading, though I still have only listened to a couple, and I could be wrong about these. It's often hard to make out the exact words, at least for me.

• 209_3M.tss: "terrible, flying weapon, and Nefarious's" -> "terrible, flying weapon of Nefarious's"
• 209_3M.tss: "Sure...." -> "Sure..."
• 207M.tss: "Good, good! but keep watching" -> "Good, good! But keep watching"
• 201_1M.tss: "As we read." -> "As we agreed."
• 200_1M.tss: "You fatted sack of pus--" -> "You fetid sack of pus--"
• 200_2M.tss: "A dead bird rises a flame" -> "A dead bird rise as a flame"
• 215_1M.tss: "Uhh?Where am I?" -> "Uhh? Where am I?"
• 215_1M.tss: "smitherins" -> "smithereens"
• 215_1M.tss: "Wait! take this!" -> "Wait! Take this!"
• 215_2M.tss: "you're early" -> "You're early."
• 215_2M.tss: "the Laurel of Fluffy's Hardy" -> "the Laurel to Fluffy's Hardy"

One line is missing from 201_2M.tss. After king Hugh says "At my-- feet!", Flux says it's "time to skedaddle".

In 200_1M.tss, after Nefarious says "you just die if you bump into them" he also says parenthetically, "'just die', I kill myself". But maybe that's too much to fit into the subtitles.

Some lines may be missing a period at the end, e.g.

• 201_1M.tss "this just doesn't seem right" -> "this just doesn't seem right."
• 201_1M.tss "leave well enough alone" -> "leave well enough alone."

But I haven't spent much time looking for those either.

[bluegr]

The issue should be fixed with this PR:
​https://github.com/scummvm/scummvm/pull/7044

Leaving it open, until the problems with the subtitles, identified above, are fixed

[BLooperZ]

THe problems in the subtitles identified above and more were already fixed in version 1.0 (available on ScummVM's website)
I believe we can close this ticket, thank you