NANCY: nancy7: WALDO tiles slower with different sound

[tunnelsociety]

At the WALDO puzzle (e.g. scene 4414) the tiles spin slower and make a different sound than in the original. Saves and recording attached.

I do *not* notice a difference for the puzzle of the same type near the end of the game. Maybe it has to do with the animation, just guessing.

[flipkick]

I've created a PR which fixes this bug: ​https://github.com/scummvm/scummvm/pull/7264

[flipkick]

Additionally to this bug, loading the attached nancy7.006 the puzzle starts with no visible letters for me. Can someone please confirm the behaviour? Maybe it's just a problem with my version of the game.

Running the original game and loading the attached NANDOG6.sav works just fine.

[flipkick]

fixed by f6b26a538d1d2544ab76f3632e997f9c0b253443 and 70961eec15e32bae620e303cb8464de6a9edca72

Closing this as fixed, but please feel free to comment if you have thoughts on my question.

[tunnelsociety]

With this change, the tiles spin extremely fast, much faster than they should. The audio is still different as it was in the video recording previously attached.

[tunnelsociety]

I reproduced the black-tiles issue. I will bisect and file a new ticket, unless they are also black with the commit of the opening date of this ticket, in which case I consider it a corrupt file or something... /shrug

[tunnelsociety]

Here is a proper save file where the tiles work. Maybe I saved that first one specifically because of the black-tiles issue, intending to report it someday, then accidentally picked it for this ticket!

[flipkick]

I overlooked that the current ScummVM code already divides the _solveDelayBetweenTurns by _currentOrder.size(). The decompiled original code doesn't do this. It just divides by the _numFramesPerTurn. This is likely the reason for the animation being too fast now. I also noticed that ScummVM adds an initial delay that I can't find in the original code.

After removing the divison I'll try to compare the animation and audio with the original game before opening another PR.

[flipkick]

I created a fix which removes the division by _currentOrder.size() and then I compared some turning puzzles in Nancy 5, 6 and 7. They now match the original game. The animation delay between animation frames is often subtle, though. For example, the delay for scene 4402 in Nancy 5 is now 250ms instead of 200ms before. For scene 3244 in Nancy 5 it's more obvious: now 500ms instead of 111ms before. Scene 4414 in nancy 7 had a 200ms delay, now it's 250ms. Scene 3859 in Nancy 6 has only one frame per turn, so the change in the delay calculation isn't visible at all.

PR: ​https://github.com/scummvm/scummvm/pull/7277

[flipkick]

The sound issue is a separate problem with the vorbis decoder, so I created a new ticket for it: https://bugs.scummvm.org/ticket/16584