Opened 11 days ago

Closed 8 days ago

Last modified 5 days ago

#15859 closed defect (fixed)

DGDS: HoC (DE) Crash after Restart and Skip to Game

Reported by: Commodusaurel Owned by: mduggan
Priority: normal Component: Engine: DGDS
Version: Keywords: Crash
Cc: Game: Heart of China

Description

If I lose a game and the game is over, i can choose Restart from the menu. If I then select "SKIP TO GAME," ScummVM crashes.

ScummVM Daily Build 08.04.25
German Floppy Version

WIN 11 23H2

Attachments (1)

scummvm.log (3.0 KB ) - added by Commodusaurel 11 days ago.

Download all attachments as: .zip

Change History (9)

by Commodusaurel, 11 days ago

Attachment: scummvm.log added

comment:1 by mduggan, 8 days ago

I tried the quickest "game over" scene I could think of at the start of the game - visiting Lomax 3 times. After restarting from that it worked fine to skip to game. I wonder if this depends on the way you get to game over. Do you remember any more detail about where you were before restarting, or a save game that reproduces it?

comment:2 by mduggan, 8 days ago

In a4b114a:

DGDS: Improve debug message on invalid image frame

This may help with debugging #15859.

comment:3 by Commodusaurel, 8 days ago

To reproduce the ScummVM crash, you can also select "Files" and "Restart" in the VCR menu after starting the game. When I then select "Skip to Game," ScummVM crashes.

comment:4 by mduggan, 8 days ago

Owner: set to mduggan
Resolution: fixed
Status: newclosed

In 73081f4d:

DGDS: Fix RST file loading in HoC

The HoC format is more like Willy Beamish than Dragon.

This should fix #15859.

comment:5 by mduggan, 8 days ago

Summary: DGDA:HoC (DE) Crash after Restart and Skip to GameDGDS: HoC (DE) Crash after Restart and Skip to Game

I still wasn't able to get it to crash on "skip to game", but I did reproduce a crash on "skip to introduction" in both en and de versions.

It turned out it was reading the RST (game reset, which is basically a special save file) incorrectly in HoC. I reordered the code a bit so now it should work. Please give it another test with that change in place and let me know how it goes.

comment:6 by Commodusaurel, 6 days ago

Keywords: Crash added

Unfortunately, I still have the problem that after a restart and then clicking on “Skip to Game” ScummVM crashed

Error Message: ERROR: Image::width: Invalid frameno 105 requested from shape 'ICONS.BMP'!

ScummVM mit Daily Build 12.04.25

comment:7 by Commodusaurel, 5 days ago

Daily Build 14.04. This Bug is FIXED! Many Thanks!

comment:8 by mduggan, 5 days ago

Great! Thanks for re-testing.

Note: See TracTickets for help on using tickets.