Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#15850 closed defect (fixed)

DGDS: HoC: Incorrect name of first savegame

Reported by: windlepoons Owned by: mduggan
Priority: normal Component: Engine: DGDS
Version: Keywords:
Cc: Game: Heart of China

Description

When I save a savegame in Hearth of China (e.g. Test1 and Test2), the first savegame appears as "Untitled saved game" when loading. The correct save list in this case would be Test1, Test2.
In the first unzipped save file, the name of the save is listed.

Hearth of China (DOS/German)
ScummVM 2.10.0git14189-g4c5af9f99f2 (Apr 5 2025 04:09:14)
OS: Siduction (Debian/sid) 64bit

Attachments (3)

Save HoC.png​ (34.9 KB ) - added by windlepoons 17 months ago.
Load HoC.png​ (35.1 KB ) - added by windlepoons 17 months ago.
First save game.png​ (5.2 KB ) - added by windlepoons 17 months ago.
Read with Hex-editor

Download all attachments as: .zip

Change History (5)

by windlepoons, 17 months ago

Attachment: Save HoC.png​ added

by windlepoons, 17 months ago

Attachment: Load HoC.png​ added

by windlepoons, 17 months ago

Attachment: First save game.png​ added

Read with Hex-editor

comment:1 by mduggan, 17 months ago

Owner: set to mduggan
Resolution: → fixed
Status: new → closed

In 07c20aa9:

GUI: Partially revert c++11 iterators in saveload-dialog

This loop needs to update the iterator after doing an insertion to correctly
skip empty slots.

This partially reverts e157b7044e0588e0178b21cc2c6edf6b6084fe56.
This fixes #15850.

comment:2 by mduggan, 17 months ago

Thanks for the report! the issue was not dgds-specific as it turns out, but I was able to find it. In this particular case it was caused by the empty autosave slot, but it could also be triggered by just saving eg in slot 10 from the start.

Note: See TracTickets for help on using tickets.