SCUMM: DOTT: Glitched cursor when loading a v2.7.x save

[dwatteau]

Adding this here after a small discussion with Bosca. (I might be interested into fixing this myself, as a way of learning more about the GFX parts of the engine.)

Attached is this DOTT save (DOS/French) release I've made on 2023-01-21 (in the last couple of weeks before building the v2.7.0 release).

FWIW, this was done:

• on a big-endian system (OSXPPC)
• during a cutscene, when Washington is about to cut the tree

This save is VER(108), which is what v2.7.0 and v2.7.1 were shipped with, so we have some interest into fixing this?

Anyway, when I load this save, even on the latest Git HEAD releases running on regular x86-64, the cursor looks very strange (see attached screenshots). It remains this way even after switching characters, moving on to a new room or cutscene, etc.

[dwatteau]

VER(108) save causing the issue (DOS/French release)

[dwatteau]

Strange cursor appearing on ScummVM 2.10.0git when loading this save

[eriktorbjorn]

I tried making a savegame at the start of the English CD version with 2.7.1 and load it into the development version, but that didn't cause any cursor problems for me.

I guess someone who has the French version will have to do the bisecting on this. (Assuming the savegame works fine with 2.7.1.)

[dwatteau]

Thanks for having a look at this!

I don't think it'd be specific to the French release, but who knows. I thought it could be related to the save having been done on a big-endian device (commit fe24a937a2dec093ccfbe7e1bd09b9ee3ba57d34 fixed something similar, a couple of years ago).

But so far, when playing with either the French or English release, on the same device, with the same ScummVM 2.7.0 release, and making a save at the same point, I can't reproduce the issue in any new save.

So I don't know, maybe it requires a very precise series of actions to happen.

I'm lowering this ticket's priority, then. If nothing similar is reported after some time, I guess this issue could be closed, too. For the moment, I just wait a bit.

[dwatteau]

VER(108) save showing the same issue with *English* DOTT

[dwatteau]

Well, I did find an early 2023 save of mine showing this issue; it's also VER(108).

What's interesting about it is that this one happened with the English release. And I doubt this one was done on a big-endian machine.