Opened 15 years ago

Closed 15 years ago

Last modified 8 months ago

#1583 closed defect (invalid)

SMUSH: Slowdown during smush playback

Reported by: SF/dirtyhairy Owned by: Kirben
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: The Dig

Description

I noticed this bug two times; once a while ago using a CVS version
(dunno when exactly, shortly after the 5.0 release, I think) on a k6-2,
500 mHz running Mandrake 9.0 (kernel 2.4.19) to play comi, and now
playing The Dig on a p2, 400 mHz, again with Mandrake 9.0 (but kernel
2.4.24): after a second or so, smush playback slows down and starts
skipping frames. Oddly, things go back to normal and play nice and
smoothly when I start moving around the mouse (!), but if I stop, it slows
down again.
I hacked around this for me by changing smush_player.cpp so that
SmushPlayer::Play warps the mouse every now and then (after trying in
vain to find out what really causes that weird beviour) - works fine, but
surely is no real solution. I attached the file, but it really is a bad, bad
hack ;)

Ticket imported from: #929778. Ticket imported from: bugs/1583.

Attachments (1)

smush_player.cpp (25.4 KB) - added by SF/dirtyhairy 15 years ago.

Download all attachments as: .zip

Change History (13)

Changed 15 years ago by SF/dirtyhairy

Attachment: smush_player.cpp added

comment:1 Changed 15 years ago by sev-

which SDL version do you use?

Can you
(a) comply your patch with our formatting standards
(b) submit diff -u old/smush_player.cpp new/smush_player.cpp

comment:2 Changed 15 years ago by sev-

back to pool

comment:3 Changed 15 years ago by sev-

Owner: sev- deleted
Summary: Slowdown during smush playbackSMUSH: Slowdown during smush playback

comment:4 Changed 15 years ago by fingolfin

Which SMUSH movie(s) are you talking about in particular? Can you give
one concrete example?

This sounds a bit as if the screen wasn't updated often enough by
smush... odd, though, I never noticed anything like this (on a G4 with
400 Mhz). If I compile w/o any optimizations, then it gets a bit slow, but
that's it...

comment:5 Changed 15 years ago by fingolfin

Owner: set to aquadran

comment:6 Changed 15 years ago by fingolfin

Owner: aquadran deleted

comment:7 Changed 15 years ago by fingolfin

BTW I don't think we need a patch from Christian - I looked at the
modified .cpp, and yeah, calling warp_mouse() most definitely isn't the
solution.

Christian, does it help any if you modifiy the delay in SmushPlayer::
play(), e.g. remove / comment out the
_vm->_system->delay_msecs(10);

comment:8 Changed 15 years ago by SF/dirtyhairy

I tried removing the delay, but this didn't help. Smush movies I tried are the
dig and comi intros.
Both systems (I just got home and tried it on my desktop - the k6-2) us the
libSDL 1.2.4 that shipped with Mandrake. I will compile newer SDL and link
against it to see if it helps when I find time, though.

comment:9 Changed 15 years ago by SF/dirtyhairy

Bad luck is me: I compiled a new libsdl 1.2.7, but I can't
find my dig CD :( . Well, anyway, I tried COMI (after all,
t'was the same issue here), the slowdown is gone here. I'll
try the dig as soon as I find my CD again. Nevertheless, I
think this can be closed - it seems to have been a SDL issue...

comment:10 Changed 15 years ago by SF/dirtyhairy

Status: newclosed

comment:11 Changed 10 years ago by Kirben

Owner: set to Kirben
Resolution: invalid

comment:12 Changed 8 months ago by digitall

Component: --Unset--Engine: SCUMM
Game: The Dig
Note: See TracTickets for help on using tickets.