Opened 11 months ago

Closed 8 months ago

#15807 closed defect (fixed)

DIRECTOR: False Positive Detection of Ancent Empires and Museum of Madness CD

Reported by: dreidrachen Owned by: tag2015
Priority: normal Component: Engine: Director
Version: Keywords: detection
Cc: Game:

Description

The game in 'F:\' seems to be an unknown game variant.

Please report the following data to the ScummVM team at https://bugs.scummvm.org/ along with the name of the game you tried to add and its version, language, etc.:

Matched game IDs for the director engine: nekojiruudonss-win

{"INSTALL1.EXE", 0, "t:9ef34796c3a6c8bc4e5a9aca562a0b81", 90304},

Change History (11)

comment:1 by dreidrachen, 11 months ago

The game in 'F:\' seems to be an unknown game variant.

Please report the following data to the ScummVM team at https://bugs.scummvm.org/ along with the name of the game you tried to add and its version, language, etc.:

Matched game IDs for the director engine: nekojiruudonss-win

{"INSTALL1.EXE", 0, "t:9ef34796c3a6c8bc4e5a9aca562a0b81", 90304},

comment:2 by AndywinXp, 11 months ago

Component: Engine: SCUMM--Unset--

comment:3 by tag2015, 11 months ago

Thanks for the report, could you provide more information? Is this https://www.mobygames.com/game/6495/museum-madness/ one of the games you are referring to?

comment:4 by tag2015, 10 months ago

Anyway, I think this is a false positive.
Could you please download a master daily build https://buildbot.scummvm.org/#/dailybuilds add the disc again and see if ScummVM detects anything?

comment:5 by tag2015, 9 months ago

Ping :)
Have you tried a daily build as asked above?

comment:6 by digitall, 9 months ago

Component: --Unset--Engine: Director
Keywords: unknown-game removed
Summary: The two games on this CD were Ancent Empires and Museum of MadnessDIRECTOR: False Positive Detection of Ancent Empires and Museum of Madness CD

comment:7 by digitall, 9 months ago

False positive from DIRECTOR engine due to this entry:
https://github.com/scummvm/scummvm/blob/master/engines/director/detection_tables.h#L7167

These could do with tightening to avoid matching various games since install1.exe, install2.exe are very generic names.

comment:8 by digitall, 9 months ago

Keywords: detection added

in reply to:  7 comment:9 by tag2015, 9 months ago

Replying to digitall:

False positive from DIRECTOR engine due to this entry:
https://github.com/scummvm/scummvm/blob/master/engines/director/detection_tables.h#L7167

These could do with tightening to avoid matching various games since install1.exe, install2.exe are very generic names.

The false positive shouldn't happen now, because that entry expects INSTALL1.EXE to be in the subdir WIN_SS.

Anyway this kind of false positives is a recurring problem in Director, there are entries that have been added a bit liberally, in some cases pretty obscure games/applications that are almost impossible to find. And the fact that one of the archivists is AWOL doesn't help :/

comment:10 by tag2015, 8 months ago

I'm closing this one. The false positive for this particular entry shouldn't happen anymore, and I doubt the OP will provide any info about those two games (which I'm almost certain are not Director)

comment:11 by tag2015, 8 months ago

Owner: set to tag2015
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.