M4: RIDDLE: Wrong palette for inventory etc.

[eriktorbjorn]

This is a known bug, but I'm filing it anyway so it doesn't get lost. The palette for the inventory and some other GUI elements is tinted blue in a way the original isn't.

This is what it looks like in DOSBox:

This is what it looks like in ScummVM:

[Random-Chain]

Still happens on Debian daily build 480f3405, with the English version.

[eriktorbjorn]

I think it may simply be that we're setting up the wrong palette in engines/m4/riddle/gui/interface.cpp, the Interface::set_interface_palette() function. I tried capturing what palette DOSBox got (so it may be slightly off), and ended up with this instead:

	gr_pal_set_RGB8(&myPalette[0], 0, 0, 0);
	gr_pal_set_RGB8(&myPalette[1], 0, 0, 0);
	gr_pal_set_RGB8(&myPalette[2], 36, 36, 36);
	gr_pal_set_RGB8(&myPalette[3], 69, 73, 69);
	gr_pal_set_RGB8(&myPalette[4], 101, 105, 101);
	gr_pal_set_RGB8(&myPalette[5], 130, 134, 130);
	gr_pal_set_RGB8(&myPalette[6], 162, 170, 162);
	gr_pal_set_RGB8(&myPalette[7], 199, 215, 207);
	gr_pal_set_RGB8(&myPalette[8], 235, 247, 231);
	gr_pal_set_RGB8(&myPalette[9], 130, 101, 60);
	gr_pal_set_RGB8(&myPalette[10], 142, 113, 73);
	gr_pal_set_RGB8(&myPalette[11], 154, 125, 89);
	gr_pal_set_RGB8(&myPalette[12], 166, 142, 105);
	gr_pal_set_RGB8(&myPalette[13], 174, 130, 113);
	gr_pal_set_RGB8(&myPalette[14], 199, 154, 130);
	gr_pal_set_RGB8(&myPalette[15], 227, 182, 142);
	gr_pal_set_RGB8(&myPalette[16], 255, 215, 158);
	gr_pal_set_RGB8(&myPalette[17], 97, 24, 36);
	gr_pal_set_RGB8(&myPalette[18], 81, 16, 24);
	gr_pal_set_RGB8(&myPalette[19], 69, 8, 16);
	gr_pal_set_RGB8(&myPalette[20], 56, 4, 12);

Which produced the following screenshot:

Which still isn't quite right. The "HANDLING STICK" text is still drawn in the wrong color. But it's a lot closer, at least.

[Strangerke]

Partially fixed in commit 7fcdfc21ea5d63eca2e0bbbb905d1a24ba378b16

But the text is similarly too dark

[Strangerke <arnaud.boutonne@…>]

In 357726ec:

M4: RIDDLE: Fix colors in TextField::draw(). That should finally fix bug #15797