Opened 15 months ago

Closed 15 months ago

Last modified 15 months ago

#15795 closed defect (fixed)

DGDS: RISE: Music Cuts Off When Restoring to Same Screen

Reported by: ArthurWalden Owned by: mduggan
Priority: normal Component: Engine: DGDS
Version: Keywords: rise, music
Cc: ArthurWalden Game: Rise of the Dragon

Description

I am using ScummVM daily build for March 12, 2025.

In Rise of the Dragon, when I restore to a location on the same screen, the music stops playing and there does not seem to be a way to restart it other than restoring to another screen or quitting and relaunching the game.

I am playing the GOG version of the game.

I am running the game on Windows 11 Home, x64, version 24H2.

Attachments (2)

rise.004 (16.6 KB ) - added by ArthurWalden 15 months ago.
rise.005 (14.9 KB ) - added by ArthurWalden 15 months ago.

Download all attachments as: .zip

Change History (12)

by ArthurWalden, 15 months ago

Attachment: rise.004 added

by ArthurWalden, 15 months ago

Attachment: rise.005 added

comment:1 by mduggan, 15 months ago

Owner: set to mduggan
Resolution: fixed
Status: newclosed

In 62e02ca0:

DGDS: Unload music file before loading game

This makes sure no matter which scene is loaded the music will be loaded fresh
and restarted.

Skip in Willy Beamish where there is only one music file that stays loaded.

This fixes #15795.

comment:2 by mduggan, 15 months ago

Thanks for the report! I just pushed a change that should fix it.

comment:3 by ArthurWalden, 15 months ago

I just tried the game with today's daily build and the same problem occurred. The bug does not appear to be fixed.

comment:4 by mduggan, 15 months ago

Hi! Since there was only 10 hours between my comment and yours, it's likely the change wasn't in the build you got. Could you check again and post the build ID if it still doesn't work?

comment:5 by ArthurWalden, 15 months ago

I'm sorry; it really doesn't work.

By "build ID," I assume you mean the equivalent of the version number on the top right of the ScummVM launcher screen. The one on the build dated March 15, 2025 is 2.10.0git13914-g968f594531d.

comment:6 by mduggan, 15 months ago

Right. 968f is before my change. You can see the history here:
https://github.com/scummvm/scummvm/commits/master/

comment:7 by ArthurWalden, 15 months ago

Unfortunately, 968f is what I downloaded from the Daily Build link on the ScummVM website. Please tell how to download the latest build.

comment:8 by mduggan, 15 months ago

It's a daily build, and as the name suggests it gets built daily.

As I write this it's still less than a day since my change, so the solution is to wait until the next daily build is created and it will include the change.

comment:9 by bluegr, 15 months ago

Please be patient, there are a lot of binaries to be built for daily builds, and this takes time.

The daily builds have been refreshed to git commit 8737ca7c, which includes this fix

comment:10 by ArthurWalden, 15 months ago

Thank you for these explanations.

Note: See TracTickets for help on using tickets.