Opened 17 months ago

Closed 17 months ago

Last modified 15 months ago

#15764 closed defect (fixed)

AGI: Unknown game variant for Sierra AGI Xmas demo

Reported by: vvdleun Owned by: sluicebox
Priority: normal Component: Engine: AGI
Version: Keywords: unknown-game
Cc: vvdleun Game:

Description

I found a Sierra XMas demo on an old copy of a shareware CD-ROM and noticed the latest version of ScummVM does not seem to support it. It identifies the game as a fanmade AGI game and it crashes during running.

Running the same demo on DOSBox does not give problems.

I've looked in the AGI detection tables source on GitHub and see several XMas Card variants, but apparently this particular one is not known yet.

I thought I'd report this. I think I can legally provide the demo files if that would help (it looks like it was made to be distributed, but unf. there is no license or README of any kind, so it's hard to tell for sure). For now I've attached some screenshots and the output of "dir".

Please let me know if I can be of further help if is anyone is willing to look into it. I've tried all usual shortcuts to try the demo to get it to report a version (ALT+D), but I couldn't get any to work.

The error that the debug console outputs when running the demo and crashes (after the Tandy screen) is: "ERROR: unexpected end of view data for view 10!".

ScummVM reports this:

The game in 'XMAS86\' seems to be an unknown game variant.

Please report the following data to the ScummVM team at https://bugs.scummvm.org/ along with the name of the game you tried to add and its version, language, etc.:

Matched game IDs for the agi engine: xmascard

{"logdir", 0, "b77b968a84e8cb70a6c9972879f485f4", 372},

Attachments (6)

agi_xmas_86_demo_1.png (64.4 KB ) - added by vvdleun 17 months ago.
agi_xmas_86_demo_2.png (13.4 KB ) - added by vvdleun 17 months ago.
agi_xmas_86_demo_3.png (39.4 KB ) - added by vvdleun 17 months ago.
agi_xmas_86_demo_4.png (45.0 KB ) - added by vvdleun 17 months ago.
dir.txt (887 bytes ) - added by vvdleun 17 months ago.
XMAS_DEMO.zip (65.6 KB ) - added by vvdleun 17 months ago.

Download all attachments as: .zip

Change History (14)

by vvdleun, 17 months ago

Attachment: agi_xmas_86_demo_1.png added

by vvdleun, 17 months ago

Attachment: agi_xmas_86_demo_2.png added

by vvdleun, 17 months ago

Attachment: agi_xmas_86_demo_3.png added

by vvdleun, 17 months ago

Attachment: agi_xmas_86_demo_4.png added

by vvdleun, 17 months ago

Attachment: dir.txt added

comment:1 by sluicebox, 17 months ago

Hello! Thanks for reporting this.

Since this just a little demo and not a full game, you could zip it up and post it here as an attachment. Then we can take look at the game resources and see what (if anything) is different on the inside, and how it compares to the other versions.

by vvdleun, 17 months ago

Attachment: XMAS_DEMO.zip added

in reply to:  1 comment:2 by vvdleun, 17 months ago

Replying to sluicebox:

Hello! Thanks for your quick reply.

Since this just a little demo and not a full game, you could zip it up and post it here as an attachment. Then we can take look at the game resources and see what (if anything) is different on the inside, and how it compares to the other versions.

As requested, I zipped and attached all demo files. See "XMAS_DEMO.zip".

comment:3 by sluicebox, 17 months ago

Thanks! This version uses a slightly newer older interpreter than the commonly seen one. I'm calling this one the Tandy version, given that there's a new scene with the Tandy logo and Tandy presents being unwrapped. The other big change is that there are no demo scenes for Sierra games.

The views are in a slightly different format in this early interpreter version, so the reindeer scene crashes.

So we have what we need to add a detection entry, but I'm going to hold off until we figure out the view format so that it doesn't crash.

Great find!

Last edited 17 months ago by sluicebox (previous) (diff)

comment:4 by sluicebox <22204938+sluicebox@…>, 17 months ago

In ee6a3a08:

AGI: Add detection for early version of XMASCARD

Thanks to @vvdleun for reporting this

Trac #15764

comment:5 by sluicebox <22204938+sluicebox@…>, 17 months ago

In 0614e80c:

AGI: Add support for v2.230 view mirror data

Used by early version of XMASCARD

Fixes error in Santa scene (room 2)

Trac #15764

comment:6 by sluicebox, 17 months ago

Owner: set to sluicebox
Resolution: fixed
Status: newclosed
Summary: Unknown game variant for Sierra AGI Xmas demoAGI: Unknown game variant for Sierra AGI Xmas demo

Detection entry added, obscure view format now supported.

This fix will appear in the next daily build of the master branch: https://buildbot.scummvm.org/#/dailybuilds

Thanks again!

comment:7 by sluicebox <22204938+sluicebox@…>, 15 months ago

In 33950cda:

AGI: Add detection for early version of XMASCARD

Thanks to @vvdleun for reporting this

Trac #15764

comment:8 by sluicebox <22204938+sluicebox@…>, 15 months ago

In e16358ba:

AGI: Add support for v2.230 view mirror data

Used by early version of XMASCARD

Fixes error in Santa scene (room 2)

Trac #15764

Note: See TracTickets for help on using tickets.