#15763 closed defect (fixed)
Error with Broken Sword is back
| Reported by: | DaLuke95 | Owned by: | lephilousophe |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Sword1 |
| Version: | Keywords: | broken sword, android, latest build | |
| Cc: | DaLuke95 | Game: | Broken Sword 1 |
Description (last modified by )
Hi,
as described in ticket https://bugs.scummvm.org/ticket/14642
Its back in the most recend play store version (and the one that is supplied via ScummVM)
Matched game IDs for the sword1 engine: sword1-win
{"clusters/scripts.clu", 0, "72b10193714e8c6e4daca51791c0db0c", 1088292},
{"clusters/swordres.rif", 0, "5463362dc77b6efc36e46ac84998bd2f", 59788},
{"clusters/text.clu", 0, "76f93f5feecc8915435105478f3c6615", 3193159},
{"video/intro.dxa", 0, "e27cd33593c08b66e8d20fbc40938789", 7397543},
All the other points from that ticket still persist for this one.
Windows install via Gog works fine, but when trying on Android 15 (Pixel Fold)it wouldnt start with the latest version.
Current workaround: Install inferior version 2.2.0 via website: https://downloads.scummvm.org/frs/scummvm/2.2.0/ and then:
scummvm-2.2.0-android-arm64-v8a.apk
Change History (17)
comment:1 by , 18 months ago
| Description: | modified (diff) |
|---|
comment:2 by , 18 months ago
| Component: | --Unset-- → Engine: Sword1 |
|---|
comment:3 by , 18 months ago
I can confirm that installing the German patch over the GOG English version of the game (Broken Sword 1) produces this message as is in the OP of this ticket in ScummVM 2.9.0 and daily developer builds -- the file size for clusters/text.clu is 3193159.
As expected, this happens regardless the platform; I tested on Windows too, so it's not an Android issue.
I also tested both options that the German patch installer provides for "subtitles for the cutscenes" (checked and unchecked), but that did not seem to change the detection message at all, so presumably the file sizes and checksums used in detection are not affected by this choice.
comment:4 by , 18 months ago
I didn't test Version 2.8.1. Didn't wanna roll back and back and back. I started on Windows via gog. But gog obviously runs Scummvm
Please try again with version 2.2.0 as I've mentioned above. It works there so between version, something was changed that is causing this. I have not moved anything to somewhere or changed anything (like a file name or so).
It didn't work with the Playstore version but worked out of the box with 2.2.0.
comment:5 by , 18 months ago
Right. I intentionally skipped over testing with 2.2.0 since I know that ScummVM's detection for the Broken Sword games did go through a significant overhaul sometime after that version and there was a call to the community to report to us their various versions they owned and stopped working so that those could be properly added.
So this issue not being present in 2.2.0 is sort of expected.
The puzzling bit for me is whether the commit that added the new detection entry did actually fix the issue (or an issue with a similar version) in the latest versions of ScummVM, or the file size mismatch is what prevents it from working as intended.
@AndywinXp probably knows more specifics on this one.
follow-up: 7 comment:6 by , 18 months ago
I can add another point to this. According to the other ticket I've linked, at 2.7 or 2.8 the game stopps working. So because I wanted to try (also for the new features and game compare) a version higher than 2.2.
2.6.1 also works flawlessly. Also, the graphics in this version seem to look better (but maybe that's just my head messing with me)
comment:7 by , 18 months ago
follow-up: 9 comment:8 by , 18 months ago
Commented by "muellrausbringen"
"Did install the latest ScummVM version 2.8.0 (did not work) and the latest daily build from Dec 16 2023 11:15:53)."
comment:9 by , 18 months ago
Replying to DaLuke95:
Commented by "muellrausbringen"
"Did install the latest ScummVM version 2.8.0 (did not work) and the latest daily build from Dec 16 2023 11:15:53)."
In my understanding this just says that 2.8.0 and the then daily dev build still had the detection error. It's not a different "stops working" error. If the latter had been the case, it would have to be reported as a separate ticket with a lot more detail for us to be able to reproduce/debug and resolve.
comment:10 by , 18 months ago
Maybe a misunderstanding between the 2 of us then. I read it as that he tried 2.8. and that also didnt work.
follow-up: 12 comment:11 by , 18 months ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
follow-up: 13 comment:12 by , 18 months ago
Replying to lephilousophe:
Sorry for someone whos not that tech savvy and also new to this ticket system what does this mean for me? :D
Is it fixed in the newest version? Can I safely download the new ScummVM from the play store? Do I need a special file or something?
Or will it come in a future release?
comment:13 by , 18 months ago
Replying to DaLuke95:
Replying to lephilousophe:
Sorry for someone whos not that tech savvy and also new to this ticket system what does this mean for me? :D
Is it fixed in the newest version? Can I safely download the new ScummVM from the play store? Do I need a special file or something?
Or will it come in a future release?
The issue is considered fixed in the current codebase. The fix will be in *tomorrow's* daily development build (2.10.0git) for supported platforms by our buildbot here (under column "latest branch master"):
https://buildbot.scummvm.org/#/dailybuilds
It will be part of a future release (technically, it will have to be backported to the 2.9 branch if it's going to be part of a potential 2.9.x bugfix release, otherwise it will be part of the next ScummVM big release be it 2.10 or other).
It will also not be on the Play Store until that time.
You can safely test with the development ScummVM build though, because it will be installed separately than the stable one, and you can have them side by side. They will use separate configuration files too.
follow-up: 15 comment:14 by , 18 months ago
Aah I see I'll wait till tomorrow then. I've been using the arm 64 v8a port. Which version do I choose tomorrow?
And I understood correctly if I use the latest branch master it'll be a separate install from my current 2.6.1 right?
Thank you so much btw that's some professional stuff u got right here
follow-up: 17 comment:15 by , 18 months ago
Replying to DaLuke95:
Aah I see I'll wait till tomorrow then. I've been using the arm 64 v8a port. Which version do I choose tomorrow?
And I understood correctly if I use the latest branch master it'll be a separate install from my current 2.6.1 right?
You can use the one from the "Android (ARM 64 bits)" row, under the "ScummVM latest
Branch master" column (tomorrow).
And, yes, it will be a separate install. You will have to configure it and add games from the start. It will be named "ScummVM (debug)" to indicate that it is a developer build of the app. It's recommended to use this debug version mainly for testing with the latest ScummVM developments/fixes.
The "ScummVM (debug)" app is only compatible for updates (upgrades to a greater version, or update for the same version, but not downgrades) with another "ScummVM (debug)" version from our daily builds.
The proper, stable "ScummVM" app is only compatible for updates (upgrades to a greater version, or update for the same version, but not downgrades) with another stable "ScummVM" version (from the Play Store or our ScummVM downloads page).
comment:16 by , 18 months ago
PERFECT! Thank you so much for fixing it and for the explanation! It is very much appreciated!
comment:17 by , 18 months ago
Replying to antoniou79:
Replying to DaLuke95:
Aah I see I'll wait till tomorrow then. I've been using the arm 64 v8a port. Which version do I choose tomorrow?
And I understood correctly if I use the latest branch master it'll be a separate install from my current 2.6.1 right?
You can use the one from the "Android (ARM 64 bits)" row, under the "ScummVM latest
Branch master" column (tomorrow).
And, yes, it will be a separate install. You will have to configure it and add games from the start. It will be named "ScummVM (debug)" to indicate that it is a developer build of the app. It's recommended to use this debug version mainly for testing with the latest ScummVM developments/fixes.
The "ScummVM (debug)" app is only compatible for updates (upgrades to a greater version, or update for the same version, but not downgrades) with another "ScummVM (debug)" version from our daily builds.
The proper, stable "ScummVM" app is only compatible for updates (upgrades to a greater version, or update for the same version, but not downgrades) with another stable "ScummVM" version (from the Play Store or our ScummVM downloads page).
Can confirm this works in the new branch master build. Cant wait till this is out in the new stable update.
Did this work for the previous version of ScummVM (ie. 2.8.1)?
The commit adding support for this version (GOG English with the German patch applied) seems to be this one:
https://github.com/scummvm/scummvm/commit/1da5439f7aee57175762708eaf6b79dbb3064b20
In the detection entry there seems to be a mismatch on the size for the clusters/text.clu file (size: 2705446) vs what's reported in this (and the old) ticket (size: 3193159). I don't know if the mismatch is intentional though or something we missed, as of yet.