Opened 6 weeks ago

Closed 4 weeks ago

#15738 closed defect (fixed)

TESTS: test/common/base64.h fails on big-endian hosts

Reported by: dwatteau Owned by: lephilousophe
Priority: normal Component: --Other--
Version: Keywords: tests, big-endian
Cc: Game:

Description

Per the 'buildd' infrastructure from Debian, the test/common/base64.h test fails on big-endian hosts, for the 2.9.0 release.

See the logs at <https://buildd.debian.org/status/package.php?p=scummvm>: the impacted archs are the big-endian ones, giving the following errors:

Running 441 tests...........................................
In Base64TestSuite::test_b64EncodeData:
./test/common/base64.h:86: Error: Expected (encoded == "AQAAAAIDAAQAAAAF"), found (AAAAAQIAAwAAAAQF != AQAAAAIDAAQAAAAF)
..
In Base64TestSuite::test_b64DecodeData:
./test/common/base64.h:121: Error: Expected (test->x == 1), found (16777216 != 1)
./test/common/base64.h:123: Error: Expected (test->z == 3), found (768 != 3)
./test/common/base64.h:124: Error: Expected (test->a == 4), found (67108864 != 4)
..........................................................................................................................................................................................................................................................................................................................................................................................................
Failed 2 of 441 tests
Success rate: 99%

(I'm just tracking the issue for now; I haven't looked at fixing it yet.)

Change History (3)

comment:1 by lephilousophe, 5 weeks ago

Owner: set to lephilousophe
Resolution: pending
Status: newclosed

I have issued PR #6441 to fix this.

comment:2 by lephilousophe, 5 weeks ago

Resolution: pendingfixed
Status: closedpending

comment:3 by Le Philousophe <lephilousophe@…>, 4 weeks ago

Status: pendingclosed

In 64e478ff:

TEST: Fix base64 test on big-endian

The structure is loaded bytewise from Base64 data and should be compared
in a little endian fashion as the Base64 test pattern was generated on a LE machine.

Closes bug:15738.

Note: See TracTickets for help on using tickets.